1.2.0: F811 when importing os/os.path

[Florian Bruhin]

Since pyflakes 1.2.0, running it over this file:

    import os.path
    import os
    assert os

produces:

    x.py:2: redefinition of unused 'os' from line 1

Switching the order of the imports works around the issue, but I think this shouldn't be an error.

[John Vandenberg (jayvdb)]

Very likely to be a bug in my patch, which was supposed to have zero effect, except for improving the error messages, but it looks like this scenario wasnt covered in the tests (the inverse scenario was covered, as you've found).

https://github.com/pyflakes/pyflakes/commit/aec68a7847d8dbd1371242f42f9302103a68178f

[John Vandenberg (jayvdb)]

The simple fix for that specific problem is https://github.com/jayvdb/pyflakes/commit/2ba836ad18168b9ba3f0d53273da217a9e4d1bb9
Build OK at https://travis-ci.org/jayvdb/pyflakes/builds/127720312

Feel free to pull it in and release a bug fix release if this is a serious problem.

However I would like a few more hours to dig further, to ensure there are no other corner cases.

fwiw, I believe there is an lp bug asking that both of these are an error, as `os.path` is unused, even though `os` is used. Need to find that bug also.

[Florian Bruhin (the-compiler)]

Thanks for the quick fix! I'm okay with waiting a bit for a patch release, I just blacklisted 1.2.0 for now :)

> fwiw, I believe there is an lp bug asking that both of these are an error, as `os.path` is unused, even though `os` is used. Need to find that bug also.

Good point, though that was just an oversight in my example - my real code where I noticed this uses both os and os.path.

[John Vandenberg (jayvdb)]

https://github.com/pyflakes/pyflakes/pull/62

and fwiw again, the other lp bug I was thinking of is https://bugs.launchpad.net/pyflakes/+bug/1153355

[John Vandenberg (jayvdb)]

Released as 1.2.1