mitaka now requires firewall driver in neutron server conf or hybrid agents break

[Kevin Benton]

Change I13e5cda8b5f3a13a60b14d80e54f198f32d7a529 added the OVS firewall driver. However, the logic that determined which VIF details to pass to Nova for hybrid plugging required that the firewall driver be set on the server side, which was not previously a requirement. This means that deployments upgrading from Liberty to Mitaka with agents using the OVS hybrid driver will break if the server is not configured with the firewall driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/311881

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/313173

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/311881
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7c7da2e3ca7ae4ca723fa26bda1a26d3fe95af95
Submitter: Jenkins
Branch: master

commit 7c7da2e3ca7ae4ca723fa26bda1a26d3fe95af95
Author: Kevin Benton <email address hidden>
Date: Fri Apr 29 21:27:41 2016 -0700

    Preserve backward compatibility with OVS hybrid plugging

    In Liberty and before, the Neutron server never had to be
    configured with a firewall driver for the OVS hybrid IPtables filtering
    bridge to work. However, in Mitaka, some logic snuck in[1] that made it
    so if the driver was not defined, the hybrid plugging would be disabled.
    This essentially broke anyone upgrading from Liberty to Mitaka who
    was using OVS and did not have the firewall driver configured on the
    server.

    This patch adjusts the default if the driver is not defined on the
    server to automatically set hyrbid plugging to true to preserve the
    Liberty behavior.

    1. I13e5cda8b5f3a13a60b14d80e54f198f32d7a529

    Closes-Bug: #1577584
    Change-Id: Ic1e316f2eb4e273e5b9fb045f1822d30af7bda68

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313173
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eca893be5b770c41cfc570dc016a41c30c2cdf23
Submitter: Jenkins
Branch: stable/mitaka

commit eca893be5b770c41cfc570dc016a41c30c2cdf23
Author: Kevin Benton <email address hidden>
Date: Fri Apr 29 21:27:41 2016 -0700

    Preserve backward compatibility with OVS hybrid plugging

    In Liberty and before, the Neutron server never had to be
    configured with a firewall driver for the OVS hybrid IPtables filtering
    bridge to work. However, in Mitaka, some logic snuck in[1] that made it
    so if the driver was not defined, the hybrid plugging would be disabled.
    This essentially broke anyone upgrading from Liberty to Mitaka who
    was using OVS and did not have the firewall driver configured on the
    server.

    This patch adjusts the default if the driver is not defined on the
    server to automatically set hyrbid plugging to true to preserve the
    Liberty behavior.

    1. I13e5cda8b5f3a13a60b14d80e54f198f32d7a529

    Closes-Bug: #1577584

    (cherry picked from commit 7c7da2e3ca7ae4ca723fa26bda1a26d3fe95af95)
    Change-Id: Ic1e316f2eb4e273e5b9fb045f1822d30af7bda68

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.1.1 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.