[tripleo-common] DibImageBuilder spews stdout/stderr

[John Trowbridge]

We do not provide any log file for the subprocess.check_call method responsible for executing disk-image-create:
https://github.com/openstack/tripleo-common/blob/master/tripleo_common/image/image_builder.py#L89

This is undesirable behavior for a library, as the code calling into the library can not change this behavior without some mock gymnastics.

In particular, I am writing an ansible module that consumes this library. Ansible uses a job status file for tracking async tasks, and the stdout/stderr from DIB is ending up in that status file. This breaks the json format of that file.

We can instead have a defaulted log file option, and pipe both stderr and stdout to that file.

[John Trowbridge (trown)]

This was fixed with https://github.com/openstack/tripleo-common/commit/29d6f749d7bab01fa3defb0c1c6e1f95b268d665

not sure why the bot didnt update this bug

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tripleo-common 5.0.0.0b1 development milestone.