Agent crash @FlowHandler::Run()

[amit surana]

3.0.2 b32

full core at

10.84.5.112:/cs-shared/bugs/<id>/

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/bin/contrail-vrouter-agent'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x0000000000c49aba in FlowHandler::Run() ()
Traceback (most recent call last):
  File "/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py", line 63, in <module>
    from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt
#0 0x0000000000c49aba in FlowHandler::Run() ()
#1 0x0000000000c45ced in Proto::RunProtoHandler(ProtoHandler*) ()
#2 0x0000000000c2a911 in FlowProto::FlowEventHandler(FlowEvent*, FlowTable*) ()
#3 0x0000000000c30f2f in QueueTaskRunner<FlowEvent*, WorkQueue<FlowEvent*> >::Run() ()
#4 0x000000000118d89c in TaskImpl::execute() ()
#5 0x00007f242a907b3a in ?? () from /usr/lib/libtbb.so.2
#6 0x00007f242a903816 in ?? () from /usr/lib/libtbb.so.2
#7 0x00007f242a902f4b in ?? () from /usr/lib/libtbb.so.2
#8 0x00007f242a8ff0ff in ?? () from /usr/lib/libtbb.so.2
#9 0x00007f242a8ff2f9 in ?? () from /usr/lib/libtbb.so.2
#10 0x00007f242ab23182 in start_thread (arg=0x7f24227bc700) at pthread_create.c:312
#11 0x00007f2429dfc47d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb)

[Prabhjot Singh Sethi (prabhjot)]

while running with multiple partitions, a flow re-eval was found to cause moment of flow from non-NAT to NAT.

which instead of falling the regular code path triggered REENTRANT flow event with deleted IPC pointer from the first run
causing segmentation fault

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19800
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19801
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19800
Committed: http://github.org/Juniper/contrail-controller/commit/48665aab1b1e62f29eecbbf86394a792f729317f
Submitter: Zuul
Branch: master

commit 48665aab1b1e62f29eecbbf86394a792f729317f
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon May 2 15:13:07 2016 +0530

Fix agent crash in FlowHandler::Run

Issue:
------
for a flow on re-evaluation if it moves from non-NAT to
NAT, instead of marking it as short flow and getting
removed it was getting re-enqueued to partition 0 with
IPC pointer being reset, causing NULL ptr access while
processing the re-enqueued message

Fix:
----
do not allow re-enqueuing of a flow update message

Closes-Bug: 1576818
Change-Id: I96a42eda7ae941da022915fd3bfe8c114a1fe437

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19801
Committed: http://github.org/Juniper/contrail-controller/commit/327a706e411ff375d07e506957234bf1b3bd3dc7
Submitter: Zuul
Branch: R3.0

commit 327a706e411ff375d07e506957234bf1b3bd3dc7
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon May 2 15:13:07 2016 +0530

Fix agent crash in FlowHandler::Run

Issue:
------
for a flow on re-evaluation if it moves from non-NAT to
NAT, instead of marking it as short flow and getting
removed it was getting re-enqueued to partition 0 with
IPC pointer being reset, causing NULL ptr access while
processing the re-enqueued message

Fix:
----
do not allow re-enqueuing of a flow update message

Closes-Bug: 1576818
Change-Id: I96a42eda7ae941da022915fd3bfe8c114a1fe437
(cherry picked from commit 48665aab1b1e62f29eecbbf86394a792f729317f)