Bad replay gain description in config menu

[Thorsten Mühlfelder]

There are some issues with the Replay Gain config menu:

These descriptions should be changed, because at the moment they don't really say what they change:
"Preamp (dB)" => "Preamp for replay gained files (dB)" AFAIK this setting only changes volume of files with Replay Gain
"Default/fallback gain (dB)" => "Preamp for not replay gained files (dB)" AFAIK this setting only changes volume of files without Replay Gain

Perhaps someone should make sure, if I'm right. But this the result of my test today ;-) and it would make sense. Most other programs have similar settings for gained/not gained files (e.g. Audacious, Amarok).

[Thorsten Mühlfelder (thenktor)]

OK, have to revert my last posting. These 2 input fields work perfectly strange :-P

* preamp 12 dB, fallback 0 dB: only gained files get louder
* preamp 0 dB, fallback -12 dB: only not gained files get lower

so far, so good :-) but:
* preamp 12 dB, fallback -12 dB: seems to be the same like preamp 12 dB, fallback 0 dB
* preamp 6 dB, fallback -12 dB: gained files get louder, not gained files get some volume like preamp 0 dB, fallback -6 dB

OK, this was heavy testing now. All was done with the same file (one with and one without replay gain).
Note that every change in these settings needs an Exaile restart to take effect.

My conclusion so far:
The preamp field works only for gained files and the fallback field works for not gained files. But if a gain is applied with the fallback field the file is seen as gained and the preamp value is applied, too. This is hard to understand for an enduser and leads to confusion.

Solutions:
* only show the preamp field to increase volume of gained files (not gained files my be to loud)
* only show the fallback field to decrease volume of not gained files (output volume will be to low for sure)
* compute the input of the 2 fields to give the right values to the gst-plugin. Example: to increase volume for gained files by 4 dB and change volume for not gained files by -4 dB (to always get a 8 dB difference between gained and not gained) the right values would be: preamp 4 dB, fallback -8 dB

[Adam Olsen (arolsen)]

Cleaning out old bugs.

[Steve Dodier-Lazaro (sidi)]

Adam, I don't understand anything about ReplayGain but I have absolutely _no way_ to translate the current options without understanding them. Could one of the devs please have a look at the ReplayGain english settings and make them easier to understand ?

[reacocard (reacocard)]

I've updated the strings in r2190 and added some glade translator comments, hopefully that helps. Unfortunately, these functions are very poorly described in both gst and the replaygain spec. :/

[Steve Dodier-Lazaro (sidi)]

I'll tell you if I manage to get this translated. Is there a way to get
tooltips with the same text as translator comments ?

[Mathias Brodala (mathbr)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi.

Steve Dodier, 25.07.2009 12:08:
> I'll tell you if I manage to get this translated. Is there a way to get
> tooltips with the same text as translator comments ?

No, and that’s good. Translator comments are by far not appropriate for
tooltips (in this case, the tooltip were way too long)

Normal tooltips should just be added.

Regards, Mathias

- --
debian/rules
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpq3U8ACgkQYfUFJ3ewsJjXXwCgk1gMtLIlF9iigqSFAWLTX/Bv
AJ8AoJs14r/iYeZ3/7XGiiajjGhc9b3r
=idVr
-----END PGP SIGNATURE-----

[reacocard (reacocard)]

> Normal tooltips should just be added.

Done in r2209