last_run_report is not generated for a single task run

[Dmitriy Kruglov]

Detailed bug description:
last_run_report.yaml report is not generated (as it used to) after executing a single task.
This prevents LCM feature from being verified.

Steps to reproduce:
1. Deploy a simple env, e.g. 1 controller + 1 compute
2. Execute an arbitrary task for a node, e.g.
fuel node --node 2 --tasks globals

Expected result: last_run_report.yaml is (re)generated for the latest task executed.
Actual result: last_run_report.yaml is not (re)generated.

Description of the environment:
MOS 9.0, build fuel-9.0-257-2016-04-28_08-00-00.iso

[Maciej Relewicz (rlu)]

can't reproduce problem on the same release, and the same workflow:

[root@nailgun ~]# fuel nodes
id | status | name | cluster | ip | mac | roles | pending_roles | online | group_id
---|----------|------------------|---------|------------|-------------------|------------|---------------|--------|---------
2 | ready | Untitled (35:46) | 1 | 10.109.0.4 | 64:51:98:e6:35:46 | compute | | True | 1
1 | ready | Untitled (e7:95) | 1 | 10.109.0.6 | 64:50:c1:a1:e7:95 | controller | | True | 1
3 | discover | Untitled (c7:11) | None | 10.109.0.3 | 64:bf:04:ef:c7:11 | | | True | None
4 | discover | Untitled (1f:c6) | None | 10.109.0.5 | 64:87:7f:13:1f:c6 | | | True | None

[root@nailgun ~]# ssh 10.109.0.4 stat /var/lib/puppet/state/last_run_report.yaml
Warning: Permanently added '10.109.0.4' (ECDSA) to the list of known hosts.
  File: ‘/var/lib/puppet/state/last_run_report.yaml’
  Size: 10900 Blocks: 24 IO Block: 4096 regular file
Device: fc01h/64513d Inode: 50915 Links: 1
Access: (0640/-rw-r-----) Uid: ( 0/ root) Gid: ( 0/ root)
Access: 2016-05-05 11:40:06.130089700 +0000
Modify: 2016-05-05 11:40:06.058089693 +0000
Change: 2016-05-05 11:40:06.058089693 +0000
 Birth: -

[root@nailgun ~]# fuel node --node 2 --tasks globals
Started tasks ['globals'] for nodes nodes [2].

[root@nailgun ~]# ssh 10.109.0.4 stat /var/lib/puppet/state/last_run_report.yaml
Warning: Permanently added '10.109.0.4' (ECDSA) to the list of known hosts.
  File: ‘/var/lib/puppet/state/last_run_report.yaml’
  Size: 8602 Blocks: 24 IO Block: 4096 regular file
Device: fc01h/64513d Inode: 50902 Links: 1
Access: (0640/-rw-r-----) Uid: ( 0/ root) Gid: ( 0/ root)
Access: 2016-05-05 11:43:57.037601507 +0000
Modify: 2016-05-05 11:43:57.005596188 +0000
Change: 2016-05-05 11:43:57.005596188 +0000
 Birth: -

[root@nailgun ~]# date
Thu May 5 11:44:04 UTC 2016

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 257
cat /etc/fuel_build_number:
 257
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6342.noarch
 fuel-misc-9.0.0-1.mos8329.noarch
 fuel-mirror-9.0.0-1.mos133.noarch
 shotgun-9.0.0-1.mos88.noarch
 fuel-openstack-metadata-9.0.0-1.mos8671.noarch
 fuel-notify-9.0.0-1.mos8329.noarch
 fuel-ostf-9.0.0-1.mos928.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8671.noarch
 python-fuelclient-9.0.0-1.mos313.noarch
 fuel-9.0.0-1.mos6342.noarch
 fuel-utils-9.0.0-1.mos8329.noarch
 fuel-nailgun-9.0.0-1.mos8671.noarch
 rubygem-astute-9.0.0-1.mos741.noarch
 fuel-library9.0-9.0.0-1.mos8329.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-agent-9.0.0-1.mos273.noarch
 fuel-ui-9.0.0-1.mos2676.noarch
 fuel-setup-9.0.0-1.mos6342.noarch
 nailgun-mcagents-9.0.0-1.mos741.noarch
 python-packetary-9.0.0-1.mos133.noarch
 fuelmenu-9.0.0-1.mos269.noarch
 fuel-bootstrap-cli-9.0.0-1.mos273.noarch
 fuel-migrate-9.0.0-1.mos8329.noarch
[root@nailgun ~]#

[Dmitriy Kruglov (dkruglov)]

Closer look into the issue showed that the problem is actually relates to requesting to execute task on a particular node. In this case nothing happens (as per puppet.log) when the particular API request is issued.
Triggering the corresponding task manually on the node, via "puppet apply --noop <MANIFEST_IN_QUESTION>" command, produces the expected result - task is executed and /var/lib/puppet/state/last_run_report.yaml report is (re)generated.

[Dmitriy Kruglov (dkruglov)]

The issue relates to recent changes made in library. Making the current issue invalid.
The following ticket will handle the issue further - https://bugs.launchpad.net/fuel/+bug/1578974.