upgrade-charm refuses to upgrade

[Stuart Bishop]

I think there are some bogus checks lurking in upgrade-charm:

~/charms/postgresql/built$ juju deploy . testy
~/charms/postgresql/built$ juju upgrade-charm --path . testy
ERROR cannot upgrade "postgresql" to "."
~/charms/postgresql/built$ juju upgrade-charm testy
ERROR upgrading a local charm requires either --path or --switch
~/charms/postgresql/built$ juju upgrade-charm --path `pwd` testy
ERROR cannot upgrade "postgresql" to "built"

Similarly, without using a relative directory to confirm that this is different to Bug #1573020:

~/charms/postgresql/built$ juju deploy `pwd` testy2
~/charms/postgresql/built$ juju upgrade-charm --path `pwd` testy2
ERROR cannot upgrade "postgresql" to "built"

~/charms/postgresql/built$ grep name metadata.yaml
"name": "postgresql"

[Stuart Bishop (stub)]

Above is from 2.0-beta6

[Cheryl Jennings (cherylj)]

Is the path you're specifying for the upgrade different than the path used to upload the charm originally? If that's the case, you need to use --switch.

[Stuart Bishop (stub)]

No, the paths are character for character identical.

[Stuart Bishop (stub)]

I suspect the trigger is that upgrade-charm thinks the directory name should match the charm name, or something like that.

[Adam Israel (aisrael)]

To add to what stub is seeing, we've also seen upgrade-charm fail with relative paths:

$ juju upgrade-charm layer-test --path=~/charms/trusty/layer-test
ERROR charm or bundle URL has invalid form: "~/charms/trusty/layer-test"

$ juju upgrade-charm layer-test --path ~/charms/trusty/layer-test/
ERROR cannot upgrade "layer-test" to ""

$ juju upgrade-charm layer-test --path ~/charms/trusty/layer-test
Added charm "local:trusty/layer-test-1" to the model.

[Stuart Bishop (stub)]

I can no longer reproduce the second example, using an absolute path. The problem still occurs using a relative path.

[Brad Crittenden (bac)]

This bug still appears for relative paths in 2.0.0-trusty-amd64. I get:

$ juju upgrade-charm horizon-juju --path .
ERROR cannot upgrade "horizon-juju" to "."

Rather than causing the user to endlessly guess what path Juju is asking you to provide, the error message could actually print it.

Error cannot upgrade "horizon-juju" from "." as it was originally deployed from
/home/bac/charms/horizon-juju-charm

[Brad Crittenden (bac)]

I can no longer reproduce this bug with 2.0.1-trusty-amd64 from juju/proposed.

Perhaps it is fixed.