listSuite.TestListJSON got null (showSuite too)

[Curtis Hovey]

As seen in
    http://reports.vapour.ws/releases/issue/5722e2c8749a5614d6efca0c

listSuite.TestListJSON got null (showSuite too)

[LOG] 0:00.003 WARNING juju.cmd.juju.cloud cloud "localhost" not available on this platform
list_test.go:76:
    // Just check a snippet of the output to make sure it looks ok.
    c.Assert(out, gc.Matches, `.*{"aws":{"defined":"public","type":"ec2","auth-types":\["access-key"\].*`)
... value string = "null"
... regex string = ".*{\"aws\":{\"defined\":\"public\",\"type\":\"ec2\",\"auth-types\":\\[\"access-key\"\\].*"

Related failures
    listSuite.TestListJSON
    listSuite.TestListYAML
    showSuite.TestListPreservesRegionOrder
    showSuite.TestShow

[Katherine Cox-Buday (cox-katherine-e)]

Suspected ordering issue.

[Eric Snow (ericsnowcurrently)]

I suspect the problem is due to how we set the Juju home directory and the fact that we've been ignoring any errors that happen when we do so. If we fail to set the Juju home directory properly, it may end up re-using an existing directory, one which may have data that invalidates our test conditions.

I suspect that is what is happening here. That is because we look for the public clouds YAML file in the home directory and fall back to some hard-coded data otherwise. These 4 failing tests are acting like that YAML file (a blank one) actually exists, even though it shouldn't. The only way that (blank) file would exist is if we were re-using an existing directory that had that blank file in it.

[Eric Snow (ericsnowcurrently)]

partial: http://reviews.vapour.ws/r/4754/

[Eric Snow (ericsnowcurrently)]

That patch has merged so now we just need to see what errors show up.

[Eric Snow (ericsnowcurrently)]

I'm not seeing any related failures in subsequent test runs.

I'm going to mark this as fix-committed. Since I expect we won't see again the specific failures reported here, any fallout can be handled in a separate bug report.