"live_migration" call in Liberty doesn't have backwards compatibility with Kilo

[Roman Sokolkov]

For upgrades we need fix for upstream bug: https://bugs.launchpad.net/nova/+bug/1576048

Description from upstrem bug:

"live_migration" call in Liberty doesn't have backwards compatibility with Kilo.

Liberty control plane and Kilo compute nodes.

Doing live-migration and getting error below on compute node

TypeError: live_migration() got an unexpected keyword argument 'migration'

Workaround(On controller): http://paste.openstack.org/show/495612/

[Roman Podoliaka (rpodolyaka)]

This is needed at least for fuel-octane, although I'm not sure we claim we support this case.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Timofey Durakov (tdurakov)]

Fix for master is already merged in upstream, stable/liberty and stable/mitaka patches are on review, going to get it them with daily patch sync, once they merged

[Roman Podoliaka (rpodolyaka)]

Patches in upstream:

https://review.openstack.org/#/c/312813/
https://review.openstack.org/#/c/312812/

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0/mitaka
Change author: Wenzhi Yu <[e-mail]>
Review: https://review.fuel-infra.org/21640

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/21640
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0/mitaka

Commit: 8ce07e486446b63f0cf1a63a561dd4c0b53c9592
Author: Wenzhi Yu <[e-mail]>
Date: Fri Jun 3 14:21:55 2016

Make compute rpcapi 'live_migration' backward compatible

This commit[1] added compute rpcapi version 4.2 which introduced a new
argument 'migration' when calling 'live_migration' method, but the code
did not ensure the backward compatibility with older version compute
node.

When calling 'live_migration' method with 'migration' argument on older
version(like Kilo) of nova compute node, a "TypeError: live_migration()
got an unexpected keyword argument 'migration'" will be threw up.

[1]https://github.com/openstack/nova/commit/2f4e64a7cf81de4a22fe2fc4210b1f795b1a3db4

Closes-Bug: #1576053

(cherry picked from commit 34b8336a41e2896f0639c402f64a05247f475fea)
Change-Id: Ie5c498d34e7c4c6573d611abd592c25f1bcb4f44

[Roman Podoliaka (rpodolyaka)]

https://review.fuel-infra.org/#/c/21640/ merged ^

[Timur Nurlygayanov (tnurlygayanov)]

The verification requires to setup complex environment, I've checked the code and fix is presented in MOS 9.0 #495. Marked as Fix Released.

[Sergii Rizvan (srizvan)]

Closed as Invalid for 8.0 because the fix was consumed via sync with stable/liberty https://review.fuel-infra.org/#/c/22251/