SM: Ordering changes causes cyclic dependency in Uninstall Roles

Bug #1576029 reported by Nitish Krishna Kaveri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
High
Abhay Joshi
Trunk
Fix Committed
High
Abhay Joshi

Bug Description

Ordering changes in check-in:
https://github.com/Juniper/contrail-puppet/commit/60a39a87bb6c1e184cf8d0c28eaf8f5587785cd8

Introduced some typos like:
https://github.com/Juniper/contrail-puppet/blob/beda2ce3428588e4fc84cdb89eba835eed5aaf0d/contrail/environment/modules/contrail/manifests/uninstall_config.pp#L62

Also double - declaration due to new file resources for Openstack provisioning:
https://github.com/Juniper/contrail-puppet/blob/beda2ce3428588e4fc84cdb89eba835eed5aaf0d/contrail/environment/modules/contrail/manifests/uninstall_config.pp#L153

And cyclic dependency in config and webui roles:

Apr 27 16:38:46 server12 puppet-agent[13189]: (Exec[provision-role-config-del] => Class[Contrail::Delete_role_config] => Service[supervisor-config] => Package[contrail-openstack-config] => File[/etc/init/neutron-server.override] => File[/etc/contrail/supervisord_config_files/contrail-api.ini] => File[/etc/contrail/supervisord_config_files/contrail-discovery.ini] => File[/etc/init.d/supervisor-config] => Class[Contrail::Delete_role_config] => Exec[provision-role-config-del])
Apr 27 16:38:46 server12 puppet-agent[13189]: (File[/etc/init.d/supervisor-webui] => Package[contrail-openstack-webui] => File[/etc/init/supervisor-webui.override] => File[/etc/init.d/supervisor-webui])
Apr 27 16:38:46 server12 puppet-agent[13189]: Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz

description: updated
description: updated
description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/19807
Submitter: Abhay Joshi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/19809
Submitter: Abhay Joshi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/19809
Committed: http://github.org/Juniper/contrail-puppet/commit/74f9abea4701603f6c3eff2b81d8fc56066e07c1
Submitter: Zuul
Branch: R3.0

commit 74f9abea4701603f6c3eff2b81d8fc56066e07c1
Author: Abhay Joshi <email address hidden>
Date: Mon May 2 09:06:41 2016 -0700

Partial-Bug: #1576029
Fix the manifest syntax errors (typo).

Change-Id: Ibfe11f819b2ee74d2f64cfc37649a49299261aa5

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/19807
Committed: http://github.org/Juniper/contrail-puppet/commit/6430a73e5da373e2a2629dc6631bf45db54fcf0e
Submitter: Zuul
Branch: master

commit 6430a73e5da373e2a2629dc6631bf45db54fcf0e
Author: Abhay Joshi <email address hidden>
Date: Mon May 2 09:06:41 2016 -0700

Partial-Bug: #1576029
Fix the manifest syntax errors (typo).

Change-Id: Ibfe11f819b2ee74d2f64cfc37649a49299261aa5

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.