Agent crash @FlowTable::UpdateKSync

[amit surana]

full core at

10.84.5.112:/cs-shared/bugs/<id>/

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/bin/contrail-vrouter-agent'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007fbc21856cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
Traceback (most recent call last):
  File "/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py", line 63, in <module>
    from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt
#0 0x00007fbc21856cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x00007fbc2185a0d8 in __GI_abort () at abort.c:89
#2 0x00007fbc2184fb86 in __assert_fail_base (fmt=0x7fbc219a0830 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n",
    assertion=assertion@entry=0x1211200 "update == false", file=file@entry=0x1211280 "controller/src/vnsw/agent/pkt/flow_table.cc", line=line@entry=886,
    function=function@entry=0x1211980 "void FlowTable::UpdateKSync(FlowEntry*, bool)") at assert.c:92
#3 0x00007fbc2184fc32 in __GI___assert_fail (assertion=0x1211200 "update == false", file=0x1211280 "controller/src/vnsw/agent/pkt/flow_table.cc",
    line=886, function=0x1211980 "void FlowTable::UpdateKSync(FlowEntry*, bool)") at assert.c:101
#4 0x00000000007aaa5c in ?? ()
#5 0x0000000000c142b3 in FlowTable::UpdateKSync(FlowEntry*, bool) ()
#6 0x0000000000c146c9 in FlowTable::AddInternal(FlowEntry*, FlowEntry*, FlowEntry*, FlowEntry*, bool, bool) ()
#7 0x0000000000c14b38 in FlowTable::Update(FlowEntry*, FlowEntry*) ()
#8 0x0000000000c2aca4 in FlowProto::UpdateFlow(FlowEntry*) ()
#9 0x0000000000c3a755 in PktFlowInfo::Add(PktInfo const*, PktControlInfo*, PktControlInfo*) ()
#10 0x0000000000c49a0d in FlowHandler::Run() ()
#11 0x0000000000c45ced in Proto::RunProtoHandler(ProtoHandler*) ()
#12 0x0000000000c2a911 in FlowProto::FlowEventHandler(FlowEvent*, FlowTable*) ()
#13 0x0000000000c30f2f in QueueTaskRunner<FlowEvent*, WorkQueue<FlowEvent*> >::Run() ()
#14 0x000000000118d89c in TaskImpl::execute() ()
#15 0x00007fbc22425b3a in ?? () from /usr/lib/libtbb.so.2
#16 0x00007fbc22421816 in ?? () from /usr/lib/libtbb.so.2
#17 0x00007fbc22420f4b in ?? () from /usr/lib/libtbb.so.2
#18 0x00007fbc2241d0ff in ?? () from /usr/lib/libtbb.so.2
#19 0x00007fbc2241d2f9 in ?? () from /usr/lib/libtbb.so.2
#20 0x00007fbc22641182 in start_thread (arg=0x7fbc196d7700) at pthread_create.c:312
#21 0x00007fbc2191a47d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

[Prabhjot Singh Sethi (prabhjot)]

flow update on BGP as a service flow, results in forward flow delete while in update and results in assertion eventually while trying to trigger update to ksync on a deleted entry

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19729
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19730
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19729
Committed: http://github.org/Juniper/contrail-controller/commit/92e685aeccbc3ae21b71141c6abf82b7e5f0cd03
Submitter: Zuul
Branch: master

commit 92e685aeccbc3ae21b71141c6abf82b7e5f0cd03
Author: Prabhjot Singh Sethi <email address hidden>
Date: Fri Apr 29 03:27:13 2016 -0700

Fix vrouter agent crash at updateksync

Issue:
------
Flow update on BGP as a service flow, results in inline
delete of forward flow, while update doesnot expect a
renew of deleted flow in update context causing assertion

Fix:
----
while trying to associate flow and reverse flow, we should
not delete reverse of reverse flow, if it is flow itself
also since we will be making it as a short flow since it
will be detached from reverse flow, we don't need an
explicit delete

Adding flow lock for missing delete all flow API

Change-Id: I6929ee4a9c4562ab30dcb6ca9650eb0b1d8c5f2d
Closes-Bug: 1575956

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19730
Committed: http://github.org/Juniper/contrail-controller/commit/b72654f89af399751afed66b9db200c937efea9c
Submitter: Zuul
Branch: R3.0

commit b72654f89af399751afed66b9db200c937efea9c
Author: Prabhjot Singh Sethi <email address hidden>
Date: Fri Apr 29 03:27:13 2016 -0700

Fix vrouter agent crash at updateksync

Issue:
------
Flow update on BGP as a service flow, results in inline
delete of forward flow, while update doesnot expect a
renew of deleted flow in update context causing assertion

Fix:
----
while trying to associate flow and reverse flow, we should
not delete reverse of reverse flow, if it is flow itself
also since we will be making it as a short flow since it
will be detached from reverse flow, we don't need an
explicit delete

Adding flow lock for missing delete all flow API

Change-Id: I6929ee4a9c4562ab30dcb6ca9650eb0b1d8c5f2d
Closes-Bug: 1575956
(cherry picked from commit 92e685aeccbc3ae21b71141c6abf82b7e5f0cd03)