NamedExtensionManager fails when loading failing extension in order

Bug #1575185 reported by xivo_dev_team
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
stevedore
Fix Released
High
ChangBo Guo(gcb)

Bug Description

Given a broken extension (raises an Exception on load)
Given another working extension
When I load the two extensions via NamedExtensionManager with name_order=True
Then NamedExtensionManager throws a KeyError

This behavior is demonstrated in the unit-test of the following Github branch:

https://github.com/openstack/stevedore/compare/master...sduthil:named-load-fail-when-sorted

When name_order is False, the broken extension is ignored, and the loading error is logged.

Is this an expected behavior?

Changed in python-stevedore:
status: New → Confirmed
assignee: nobody → ChangBo Guo(gcb) (glongwave)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stevedore (master)

Fix proposed to branch: master
Review: https://review.openstack.org/337043

Changed in python-stevedore:
status: Confirmed → In Progress
Changed in python-stevedore:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stevedore (master)

Reviewed: https://review.openstack.org/337043
Committed: https://git.openstack.org/cgit/openstack/stevedore/commit/?id=1218ab61a124ead05feea3b10077f06ea551aef6
Submitter: Jenkins
Branch: master

commit 1218ab61a124ead05feea3b10077f06ea551aef6
Author: ChangBo Guo(gcb) <email address hidden>
Date: Mon Jul 4 15:35:31 2016 +0800

    Fix NamedExtensionManager fails when loading failing extension in order

    NamedExtensionManager refer to extensions by names passed by caller.
    A keyError is raised when name_order=True and can't load all extensions.

    Closes-Bug: #1575185
    Change-Id: I79769d4296efe98727751adc19bb8f33d75ba729

Changed in python-stevedore:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/stevedore 1.16.0

This issue was fixed in the openstack/stevedore 1.16.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.