tempest test_preserve_preexisting_port fails, "Unrecognized attribute(s) 'dns_name'"

[Hiroyuki Ito]

tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_preserve_preexisting_port failed like the following error:

http://logs.openstack.org/43/306343/4/check/gate-tempest-dsvm-networking-midonet-v2/193b941/

Traceback (most recent call last):
      File "tempest/test.py", line 113, in wrapper
         return f(self, *func_args, **func_kwargs)
       File "tempest/scenario/test_network_basic_ops.py", line 662, in test_preserve_preexisting_port
         self.assertEqual('', port['device_id'])
       File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 406, in assertEqual
         self.assertThat(observed, matcher, message)
       File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 493, in assertThat
         raise mismatch_error
     testtools.matchers._impl.MismatchError: '' != u'260b6313-90e9-47f7-90b8-74f4a75877ab'

I wonder if the following neutron server error is related and it is related to the current nova change(*):

2016-04-25 07:29:01.069 21424 INFO neutron.api.v2.resource [req-408f3e48-a219-4748-908c-7eeeb28d932c neutron -] update failed (client error): Unrecognized attribute(s) 'dns_name'
2016-04-25 07:29:01.070 21424 INFO neutron.wsgi [req-408f3e48-a219-4748-908c-7eeeb28d932c neutron -] 127.0.0.1 - - [25/Apr/2016 07:29:01] "PUT /v2.0/ports/6476e377-74a4-4872-8a7f-f792b3420794.json HTTP/1.1" 400 332 0.003440

(*) change-id: I65edb33b955a91d1701fc91cb9fae0a5f26d4e46

[YAMAMOTO Takashi (yamamoto)]

i added nova to the bug because it looks like a nova bug.
ie. missing "constants.DNS_INTEGRATION in self.extensions" check.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/310347

[Matt Riedemann (mriedem)]

Confirmed, this breaks the OVN and Midonet voting jobs:

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22update%20failed%20(client%20error)%3A%20Unrecognized%20attribute(s)%20'dns_name'%5C%22%20AND%20tags%3A%5C%22screen-q-svc.txt%5C%22%20AND%20voting%3A1&from=7d

[Matt Riedemann (mriedem)]

I'll push a fix for nova. This is why random attributes in unversioned dictionaries being passed between nova and neutron are bad, especially when using optional extensions in Neutron also.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/310474

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310474
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b256cae8e204fbbf6f3d40f5f4d47013be018a6d
Submitter: Jenkins
Branch: master

commit b256cae8e204fbbf6f3d40f5f4d47013be018a6d
Author: Matt Riedemann <email address hidden>
Date: Wed Apr 27 09:47:59 2016 -0400

    Only reset dns_name when unbinding port if DNS is integrated

    We only set the dns_name on the port if the "DNS Integration"
    extension is enabled, so we should only reset it on the port
    when unbinding if the extension is enabled, otherwise some
    Neutron stadium plugins will fail since they don't expect
    the 'dns_name' attribute to be on the port.

    Change-Id: I7451fbfad53236e9e147a0387dac45ae97f3e75b
    Closes-Bug: #1574565

[OpenStack Infra (hudson-openstack)]

Change abandoned by Hiroyuki Ito (<email address hidden>) on branch: master
Review: https://review.openstack.org/310347

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/312312

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/312312
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=00dd02f28f83121ff0ec409f338a0c75bec5c03c
Submitter: Jenkins
Branch: stable/mitaka

commit 00dd02f28f83121ff0ec409f338a0c75bec5c03c
Author: Matt Riedemann <email address hidden>
Date: Wed Apr 27 09:47:59 2016 -0400

    Only reset dns_name when unbinding port if DNS is integrated

    We only set the dns_name on the port if the "DNS Integration"
    extension is enabled, so we should only reset it on the port
    when unbinding if the extension is enabled, otherwise some
    Neutron stadium plugins will fail since they don't expect
    the 'dns_name' attribute to be on the port.

    NOTE(mriedem): This backport adds an import that wasn't in
    stable/mitaka but is used in the unit test from the original
    patch.

    Change-Id: I7451fbfad53236e9e147a0387dac45ae97f3e75b
    Closes-Bug: #1574565
    (cherry picked from commit b256cae8e204fbbf6f3d40f5f4d47013be018a6d)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 13.1.0 release.