External load balancer support is broken

[Aleksandr Didenko]

External LB and moving controllers into different racks is currently broken.

Steps to reproduce:
1) Build and install https://github.com/openstack/fuel-plugin-external-lb
2) Create multirack env with controllers in different racks
3) Deploy

Expected result:
deployment successful

Actual result:
deployment failed

Version info:
reproduced on fuel-9.0-191-2016-04-12_02-00-00.iso

[Aleksandr Didenko (adidenko)]

It's by this change:

https://review.openstack.org/#/c/224857/71/deployment/puppet/osnailyfacter/modular/virtual_ips/conntrackd.pp

The following conditional is missing after that patch:
if $network_metadata['vips']["vrouter_${vrouter_name}"]['namespace'] {

So we need to put it back in order to fix this bug and also add a noop tests to avoid such regressions in the future.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/309449

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309449
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e0ef70d91a98225921b1111c76ad61559d5a1ba2
Submitter: Jenkins
Branch: master

commit e0ef70d91a98225921b1111c76ad61559d5a1ba2
Author: Aleksandr Didenko <email address hidden>
Date: Fri Apr 22 16:48:38 2016 +0200

    Fix conntrackd for external LB use case

    Do not configure conttrackd resource for non-existing VIP.

    Change-Id: Iee314c991aaeab84718d083b273090422ffc4ae0
    Closes-bug: #1573583

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/310132

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310132
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ae67dc251e3b23b2a77a37dda0c2852a1a76f08e
Submitter: Jenkins
Branch: stable/mitaka

commit ae67dc251e3b23b2a77a37dda0c2852a1a76f08e
Author: Aleksandr Didenko <email address hidden>
Date: Fri Apr 22 16:48:38 2016 +0200

    Fix conntrackd for external LB use case

    Do not configure conttrackd resource for non-existing VIP.

    Change-Id: Iee314c991aaeab84718d083b273090422ffc4ae0
    Closes-bug: #1573583
    (cherry picked from commit e0ef70d91a98225921b1111c76ad61559d5a1ba2)

[Nastya Urlapova (aurlapova)]

Moved to "Fix released", since tests separate_haproxy passed on ISO#510:
https://product-ci.infra.mirantis.net/view/9.0_swarm/job/9.0.system_test.ubuntu.plugins.thread_separate_haproxy/15/testReport/(root)/separate_haproxy/separate_haproxy/