Bug #1573479 “Users email can not delete by updating user” : Bugs : OpenStack Dashboard (Horizon)

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-22:

#1

This issue found on icehouse and recreated on kilp, but in the current code, it appears to still be an issue.

forilen (huyulin2011) on 2016-04-24

Changed in horizon:
assignee:	nobody → forilen (huyulin2011)

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-25:

#2

Hi forilen, is there any clue you have found to fix it? Please guide me, thanks!

Revision history for this message

Itxaka Serrano (itxaka) wrote on 2016-04-25:

#3

I cant reproduce this on mitaka/liberty/kilo.

- Created user test with email <email address hidden>
- Edited user and removed email

And everything went ok.

Can you provide more info on this?

Revision history for this message

Itxaka Serrano (itxaka) wrote on 2016-04-25:

#4

BTW, tested against kilo and liberty keystone backends just in case, in both cases it worked.

Changed in horizon:
status:	New → Incomplete

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#5

Hi Itxaka, I definitely can create this issue on my env with identity-api-version is 2.0 (kilo release). What the identity api version are you using? V3?

I would like to paste my screen shot for you ,but I don't know how to upload. Could you please guide me?

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#6

Hi Itxaka, this issue only occurred on Horizon UI, the keystone command can do this successfully.

Does you also tried it on Horizon UI? or using the keystone command?

forilen (huyulin2011) on 2016-04-26

Changed in horizon:
assignee:	forilen (huyulin2011) → nobody

Zhang Yun (zhangyun) on 2016-04-26

Changed in horizon:
status:	Incomplete → New

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#7

I build up a Newton devstack env and retry this issue, after I update the user on horizon UI , the UI will prompts this error - "Error: Unable to update the user". So the update user on Horizon UI is definitely has problem.

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#8

devstack_horizonUI_error.jpg Edit (40.8 KiB, image/jpeg)

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#9

recreate_issue_on_horizon_kilo_1.jpg Edit (44.9 KiB, image/jpeg)

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#10

recreate_issue_on_horizon_kilo_2.jpg Edit (70.3 KiB, image/jpeg)

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#11

recreate_issue_on_horizon_kilo_3.jpg Edit (34.7 KiB, image/jpeg)

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#12

recreate_issue_on_horizon_kilo_4.jpg Edit (63.6 KiB, image/jpeg)

Revision history for this message

Itxaka Serrano (itxaka) wrote on 2016-04-26:

#13

Indeed, Im using v3, so this may only affect v2. Let me try to set up an env with v2 and retry. Thanks!

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-04-26:

#14

Yes, Itxaka, this issue only occur on v2. If you find any clue, please guide me here. Thanks.

Revision history for this message

Rob Cresswell (robcresswell-deactivatedaccount) wrote on 2016-05-02:

#15

I've tested on v2, and unable to recreate the issue either.

Changed in horizon:
status:	New → Incomplete

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-05-04:

#16

Rob, which release you used? If possible, would you please paste some screenshot?

I also build up a Newton devstack env and retry this issue, after I update the user on horizon UI , the UI will prompts this error - "Error: Unable to update the user". So the update user on Horizon UI is definitely has problem.

Changed in horizon:
status:	Incomplete → New

Revision history for this message

Rob Cresswell (robcresswell-deactivatedaccount) wrote on 2016-05-04:

#17

This was on Newton. Can you update through the CLI?

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-05-05:

#18

Yes, the CLI can work as expect, the error only occur on the Horizon UI.

On your Newton env, the CLI and UI both can work normally?

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-05-09:

#19

I tried on the latest Newton devtack env today, the issue still exist.
On horizon UI, I can not edit the user to remove the email with V2, but the CLI can.

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-05-31:

#20

Download full text (6.2 KiB)

I tired to modify the code of Kilo release to fix this issue as below:

Change /usr/share/openstack-dashboard/openstack_dashboard/dashboards/identity/users/forms.py

Original:
    201 try:
    202 if "email" in data:
    203 data['email'] = data['email'] or None

Modified:
    201 try:
    202 if "email" in data:
    203 data['email'] = data['email'] or ''

Then restart the httpd service. This issue has gone.

But when running the UT for this new changed file, I failed the Jenkins with py27 test. Below is my modified UT code and the prompts error:

Could some one can help me on this? It has troubled me some days. Thanks a lot!

Change /usr/share/openstack-dashboard/openstack_dashboard/dashboards/identity/users/tests.py
Original:
346 formData = {'method': 'UpdateUserForm', 347
347 'id': user.id,
348 'name': user.name,
349 'email': "",
350 'project': self.tenant.id}

Modified:
346 formData = {'method': 'UpdateUserForm', 347
347 'id': user.id,
348 'name': user.name,
349 'email': '', ---> changed here
350 'project': self.tenant.id}

The UT promots error as below:
======================================================================
FAIL: test_update_with_no_email_attribute (openstack_dashboard.dashboards.identity.users.tests.UsersViewTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/openstack_dashboard/test/helpers.py", line 112, in instance_stub_out
    return fn(self, *args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/openstack_dashboard/dashboards/identity/users/tests.py", line 353, in test_update_with_no_email_attribute
    res = self.client.post(USER_UPDATE_URL, formData)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 482, in post
    secure=secure, **extra)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 296, in post
    secure=secure, **extra)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 358, in generic
    return self.request(**r)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 440, in request
    six.reraise(*exc_info)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/home/je...

I tired to modify the code of Kilo release to fix this issue as below:

Change /usr/share/openstack-dashboard/openstack_dashboard/dashboards/identity/users/forms.py

Original: 
    201         try:
    202             if "email" in data:
    203                 data['email'] = data['email'] or None

Modified: 
    201         try:
    202             if "email" in data:
    203                 data['email'] = data['email'] or ''

Then restart the httpd service. This issue has gone.

But when running the UT for this new changed file, I failed the Jenkins with py27 test. Below is my modified UT code and the prompts error:

Could some one can help me on this? It has troubled me some days. Thanks a lot!

Change /usr/share/openstack-dashboard/openstack_dashboard/dashboards/identity/users/tests.py
Original:
346	        formData = {'method': 'UpdateUserForm',	347	       
347	                    'id': user.id,		                   
348	                    'name': user.name,		                  
349	                    'email': "",		                  
350	                    'project': self.tenant.id}

Modified:
346	        formData = {'method': 'UpdateUserForm',	347	       
347	                    'id': user.id,		                   
348	                    'name': user.name,		                  
349	                    'email': '', ---> changed here		                  
350	                    'project': self.tenant.id}

The UT promots error as below:
======================================================================
FAIL: test_update_with_no_email_attribute (openstack_dashboard.dashboards.identity.users.tests.UsersViewTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/openstack_dashboard/test/helpers.py", line 112, in instance_stub_out
    return fn(self, *args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/openstack_dashboard/dashboards/identity/users/tests.py", line 353, in test_update_with_no_email_attribute
    res = self.client.post(USER_UPDATE_URL, formData)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 482, in post
    secure=secure, **extra)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 296, in post
    secure=secure, **extra)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 358, in generic
    return self.request(**r)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/test/client.py", line 440, in request
    six.reraise(*exc_info)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/decorators.py", line 52, in dec
    return view_func(request, *args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/openstack_dashboard/dashboards/identity/users/views.py", line 85, in dispatch
    return super(UpdateView, self).dispatch(*args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/views/generic/base.py", line 87, in dispatch
    return handler(request, *args, **kwargs)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/django/views/generic/edit.py", line 173, in post
    return self.form_valid(form)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/forms/views.py", line 173, in form_valid
    exceptions.handle(self.request)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/exceptions.py", line 385, in handle
    six.reraise(exc_type, exc_value, exc_traceback)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/forms/views.py", line 170, in form_valid
    handled = form.handle(self.request, form.cleaned_data)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/openstack_dashboard/dashboards/identity/users/forms.py", line 217, in handle
    response = exceptions.handle(request, ignore=True)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/horizon/exceptions.py", line 385, in handle
    six.reraise(exc_type, exc_value, exc_traceback)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/openstack_dashboard/dashboards/identity/users/forms.py", line 209, in handle
    response = api.keystone.user_update(request, user, **data)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/mox.py", line 765, in __call__
    return mock_method(*params, **named_params)
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/mox.py", line 1002, in __call__
    expected_method = self._VerifyMethodCall()
  File "/home/jenkins/workspace/gerrit-horizon-es-py27/.tox/py27/local/lib/python2.7/site-packages/mox.py", line 1060, in _VerifyMethodCall
    raise UnexpectedMethodCallError(self, expected)
UnexpectedMethodCallError: Unexpected method call.  unexpected:-  expected:+
- user_update.__call__(<class 'django.http.HttpRequest'>, u'5', email='', name=u'user_five', project=u'1') -> None
?                                                         -           ^^       -                     -

+ user_update.__call__(<class 'django.http.request.HttpRequest'>, '5', email=None, name='user_five', project='1') -> None
?                                          ++++++++                          ^^^^

>>  raise UnexpectedMethodCallError(self, expected)

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-05-31:

#21

Could some one can help me on this Jenkins error? It has troubled me some days. Thanks a lot!

Revision history for this message

Zhang Yun (zhangyun) wrote on 2016-06-02:

#22

Submit one patch to fix it. https://review.openstack.org/#/c/324526/

Changed in horizon:
assignee:	nobody → Zhang Yun (zhangyun)

Rob Cresswell (robcresswell-deactivatedaccount) on 2017-03-02

Changed in horizon:
assignee:	Zhang Yun (zhangyun) → nobody
status:	New → Confirmed
tags:	added: low-hanging-fruit ocata-backport-potential
Changed in horizon:
importance:	Undecided → Low
milestone:	none → next

lahari (ananda-bhavaraju) on 2017-03-25

Changed in horizon:
assignee:	nobody → lahari (ananda-bhavaraju)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-09: Fix proposed to horizon (master)

#23

Fix proposed to branch: master
Review: https://review.openstack.org/492286

Changed in horizon:
assignee:	lahari (ananda-bhavaraju) → Lucas H. Xu (xuh-2)
status:	Confirmed → In Progress

Ying Zuo (yingzuo) on 2017-08-16

Changed in horizon:
milestone:	next → queens-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-16: Fix merged to horizon (master)

#24

Reviewed: https://review.openstack.org/492286
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a9517ff6151be22a4aa5dccd8389b358f591a92b
Submitter: Jenkins
Branch: master

commit a9517ff6151be22a4aa5dccd8389b358f591a92b
Author: Lucas H. Xu <email address hidden>
Date: Wed Aug 9 16:30:46 2017 -0400

Fix cannot delete user's email addresses in the identity/user panel

How to reproduce the bug:

P.S. Using the horizon master(pike) codebase

    1) Login as an admin user
    2) Click Identity and go to the Users panel
    3) Create a user and put an email address with that user
    4) Then edit this user to clear the email address.
    5) Update the user and even though we have a green banner(successful)
    show up, the email address still viewable and do not disappear.

Closes Bug: #1573479

Change-Id: I0273d0c6d885c77f1f74bdc2ae6674d1e6539ac0

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-16: Fix proposed to horizon (stable/ocata)

#25

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/494073

Ying Zuo (yingzuo) on 2017-08-16

tags:

added: pike-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-16: Fix proposed to horizon (stable/pike)

#26

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/494074

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-20: Change abandoned on horizon (stable/ocata)

#27

Change abandoned by Ying Zuo (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/494073
Reason: too late to backport to stable/ocata

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-20: Fix merged to horizon (stable/pike)

#28

Reviewed: https://review.openstack.org/494074
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3e298076985695ae370f0292c51545ac408fddb0
Submitter: Jenkins
Branch: stable/pike

commit 3e298076985695ae370f0292c51545ac408fddb0
Author: Lucas H. Xu <email address hidden>
Date: Wed Aug 9 16:30:46 2017 -0400

Fix cannot delete user's email addresses in the identity/user panel

How to reproduce the bug:

P.S. Using the horizon master(pike) codebase

    1) Login as an admin user
    2) Click Identity and go to the Users panel
    3) Create a user and put an email address with that user
    4) Then edit this user to clear the email address.
    5) Update the user and even though we have a green banner(successful)
    show up, the email address still viewable and do not disappear.

Closes Bug: #1573479

Change-Id: I0273d0c6d885c77f1f74bdc2ae6674d1e6539ac0
(cherry picked from commit a9517ff6151be22a4aa5dccd8389b358f591a92b)

tags:

added: in-stable-pike

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-27: Fix included in openstack/horizon 13.0.0.0b1

#29

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-11-21: Fix included in openstack/horizon 12.0.1

#30

This issue was fixed in the openstack/horizon 12.0.1 release.

Akihiro Motoki (amotoki) on 2018-01-16

tags:

removed: ocata-backport-potential pike-backport-potential

OpenStack Dashboard (Horizon)

Users email can not delete by updating user

Bug Description

Other bug subscribers

Bug attachments

Remote bug watches