widelands

Font selection and BiDi broken in Windows

Bug #1572879 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned
widelands build19-rc1

Bug Description

In Options -> Language, Arabic is displayed from left to right instead of being parsed by the BiDi algorithm. Also, some fonts are not used, resulting in empty squares.

I found this with Windows 7, but not on Unix. Which ICU version do we have on the Windows packages? I have 52.1 on Ubuntu.

Related branches

lp:~widelands-dev/widelands/bug-1572879-broken_bidi
Tino: Approve
GunChleoc: Approve
Diff: 74 lines (+7/-7)
3 files modified
src/graphic/text/bidi.cc (+5/-5)
src/graphic/text_layout.cc (+1/-1)
src/graphic/wordwrap.cc (+1/-1)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Screenshots -Ubuntu on top, Windows on the bottom.

Revision history for this message
Tino (tino79) wrote :

For my builds (widelands.8-schuss.de) : ICU 56.1
For Appveyor: ICU 56.1 (see logs)

Changed in widelands:
status: New → Confirmed
Revision history for this message
GunChleoc (gunchleoc) wrote :

I'm stuck with ICU 52 for now, and even with Ubuntu 16.04, I can only get version 55. Could you make a Windows build with ICU 52.1 to check if the problems go away?

http://site.icu-project.org/download/52

Revision history for this message
Miroslav Remák (miroslavr256) wrote :

I can reproduce this on Debian with ICU 55.1. Looks exactly like on your Windows screenshot.

In addition, see the attached screenshot for the weirdness that happens when I switch to Arabic and restart the game...

Revision history for this message
kaputtnik (franku) wrote :

On archlinux everything is fine with icu 57.1-1 (tested with branch revised_map_descr)

Revision history for this message
GunChleoc (gunchleoc) wrote :

I just upgraded my Ubuntu, and everything's fine with ICU 55.1 for me. So, I expect that the ICU version is not the problem. I suspect that the Unicode code blocks don't get identified properly, but I have no idea why.

summary: - Font selection and BiDi broken in WIndows
+ Font selection and BiDi broken in Windows
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.