Replace hardcoded values with $::os_service_default for nova, cinder, neutron

[Max Yatsenko]

Now we have hardcoded values for 'report_interval', 'service_down_time', 'agent_down_time' parameters:

osnailyfacter/manifests/globals/globals.pp:

  $nova_report_interval = hiera('nova_report_interval', 60)
  $nova_service_down_time = hiera('nova_service_down_time', 180)
  $cinder_report_interval = hiera('cinder_report_interval', 60)
  $cinder_service_down_time = hiera('cinder_service_down_time', 10)
  $neutron_report_interval = hiera('neutron_report_interval', 10)
  $neutron_agent_down_time = hiera('neutron_agent_down_time', 30)

Not all values are correct, to solve the issue hardcoded values should be replaced by $::os_service_default

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/308831

[Ivan Berezovskiy (iberezovskiy)]

These values should be fixed for other components as well. But in case of cinder following params are confused:

$cinder_report_interval = hiera('cinder_report_interval', 60) and $cinder_service_down_time = hiera('cinder_service_down_time', 10)

cinder_report_interval should be 10, cinder_service_down_time should be 60. And it has to be backported to 9.0

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/310469

[OpenStack Infra (hudson-openstack)]

Change abandoned by Maksym Yatsenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/308831

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310469
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=09c1f1f2144c32916b085c23dc3afd918783359b
Submitter: Jenkins
Branch: master

commit 09c1f1f2144c32916b085c23dc3afd918783359b
Author: Alexey Deryugin <email address hidden>
Date: Wed Apr 27 16:36:34 2016 +0300

    Switch values for cinder_report_interval and cinder_service_down_time

    Values for cinder_report_interval and cinder_service_down_time are confused
    and should be switched. cinder_report_interval should be 10 instead of 60, and
    cinder_service_down_time should be 60 instead of 10.

    Change-Id: Icb1404bbac89bd978296e4194a9f334874da05ca
    Closes-Bug: #1568803
    Related-Bug: #1572689

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/313265

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313265
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2b59f978bebd30b0701c57c4cd8431d2ffc10fc0
Submitter: Jenkins
Branch: stable/mitaka

commit 2b59f978bebd30b0701c57c4cd8431d2ffc10fc0
Author: Alexey Deryugin <email address hidden>
Date: Wed Apr 27 16:36:34 2016 +0300

    Switch values for cinder_report_interval and cinder_service_down_time

    Values for cinder_report_interval and cinder_service_down_time are confused
    and should be switched. cinder_report_interval should be 10 instead of 60, and
    cinder_service_down_time should be 60 instead of 10.

    Change-Id: Icb1404bbac89bd978296e4194a9f334874da05ca
    Closes-Bug: #1568803
    Related-Bug: #1572689
    (cherry picked from commit 09c1f1f2144c32916b085c23dc3afd918783359b)

[Ivan Berezovskiy (iberezovskiy)]

We don't have a plans to change these values to default for 9.0. For 10.0 this issue should be investigated.

[Timur Nurlygayanov (tnurlygayanov)]

Ok marked as Fix Released for 9.0 and still in progress for 10.0

[Igor Gajsin (igajsin)]

The review https://review.openstack.org/#/c/310469/ was merged to master. So, there is no bug for Fuel 10 and later.