Action list "link" actions broken after patch #295605

Bug #1572386 reported by Richard Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Richard Jones

Bug Description

The fix for bug 1560303 in https://review.openstack.org/#/c/295605 broke when any "link" type action was included in the actions list. This broke in the new Swift UI.

The fix is either to revert patch 295605, fix the link actions or to change the Swift UI to not use link actions.

Altering the implementation of link actions is unlikely because to do so would require significant changes across the action-list implementation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/308129

Changed in horizon:
assignee: nobody → Richard Jones (r1chardj0n3s)
status: New → In Progress
Changed in horizon:
importance: Undecided → Critical
importance: Critical → High
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/308129
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ea6d708f06645d4fb3d78676a0a20d36066ee957
Submitter: Jenkins
Branch: master

commit ea6d708f06645d4fb3d78676a0a20d36066ee957
Author: Richard Jones <email address hidden>
Date: Wed Apr 20 13:53:31 2016 +1000

    Remove broken "link" type action

    This change also requires switching the Swift UI over
    to using a regular button instead of the link.

    Change-Id: I41fbed21614c3ea81aed0ad2bfa98ea31980a01b
    Closes-Bug: 1572386
    Closes-Bug: 1567830

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.