Check that row is defined when wait cell status

Bug #1572036 reported by Sergei Chipiga
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Sergei Chipiga

Bug Description

During cell status waiting we need to verify that row is defined before asking row.cells. DOM is inconstant structure in time, and we may call _get_row, when table is not in DOM (for ex, when table is reloaded). So we should consider that situation and don't raise Exception that NoneType hasn't 'cells' attribute.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/307667

Changed in horizon:
assignee: nobody → Sergei Chipiga (schipiga)
status: New → In Progress
Changed in horizon:
importance: Undecided → Low
milestone: none → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/307667
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5d8161147ee3cc41d4853aabb6f049f2093892e7
Submitter: Jenkins
Branch: master

commit 5d8161147ee3cc41d4853aabb6f049f2093892e7
Author: Sergei Chipiga <email address hidden>
Date: Tue Apr 19 12:12:04 2016 +0300

    Check that row is defined when wait cell status

    Change-Id: I848b2d14138a362040abc516e32061d0b3570394
    Closes-Bug: #1572036

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → newton-1
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/310666
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0ec6dd5fe106d79e0d80654aff384e0accc5bdbc
Submitter: Jenkins
Branch: master

commit 0ec6dd5fe106d79e0d80654aff384e0accc5bdbc
Author: Sergei Chipiga <email address hidden>
Date: Thu Apr 28 08:18:59 2016 +0300

    Define row in cell_getter before check cell status

    Closes-Bug: #1572036
    Change-Id: I633cdcfca226cd94a14266baeec7ab800f22dadb

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.