Nova server was created in incorrect security_group

[huangtianhua]

1. create a stack with nova server:
***************************
server:
    type: OS::Nova::Server
    properties:
      image: { get_param: image }
      flavor: { get_param: flavor }
      key_name: { get_param: key_name }
      user_data_format: SOFTWARE_CONFIG
      networks:
      - network: 69f998ce-05f0-4d97-8dc0-aa51ee0c6d0f
        subnet: 86d410e2-0905-4026-966e-0270de952bb7
        floating_ip: {get_resource: floatingip}
      security_groups:
      - {get_resource: the_sg}
****************************************
2. the server created successful, but I found the server in security_group "default"
3. if user specified the subnet, heat will create an internal port, but didn't specify the security_group for the port.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/314048

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314048
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=66b6490705affa7e11b4fce43f8f1face9e8767b
Submitter: Jenkins
Branch: master

commit 66b6490705affa7e11b4fce43f8f1face9e8767b
Author: huangtianhua <email address hidden>
Date: Mon May 9 19:01:23 2016 +0800

    Set security_groups when create internal ports for nova server

    Make sure nova server be created in correct security groups
    if user specified subnet and security_groups when create/update
    server.

    Change-Id: Ic93cad4def90f3da25390d871d6a8c14ffe1c5ae
    Closes-Bug: #1571975

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/317673

[Zane Bitter (zaneb)]

Do we know when this bug was introduced? (i.e. do we need a backport to Liberty also?)

[huangtianhua (huangtianhua)]

Will look into it, if the bug was introduced in liberty, will backport it.

[huangtianhua (huangtianhua)]

We support to create internal port in 8/27/2015, so we need to backport to liberty, will propose a patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/317918

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317918
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c775afcd3d23d9ebe1172246f71a577a83aed387
Submitter: Jenkins
Branch: stable/liberty

commit c775afcd3d23d9ebe1172246f71a577a83aed387
Author: huangtianhua <email address hidden>
Date: Mon May 9 19:01:23 2016 +0800

    Set security_groups when create internal ports for nova server

    Make sure nova server be created in correct security groups
    if user specified subnet and security_groups when create/update
    server.

    Closes-Bug: #1571975
    (cherry picked from commit 66b6490705affa7e11b4fce43f8f1face9e8767b)

    Conflicts:
     heat/engine/resources/openstack/nova/server_network_mixin.py
     heat/tests/nova/test_server.py
     heat_integrationtests/functional/test_nova_server_networks.py

    Change-Id: Ic93cad4def90f3da25390d871d6a8c14ffe1c5ae

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317673
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=20399582c9dca6494911b82232c7dbd23521d062
Submitter: Jenkins
Branch: stable/mitaka

commit 20399582c9dca6494911b82232c7dbd23521d062
Author: huangtianhua <email address hidden>
Date: Mon May 9 19:01:23 2016 +0800

    Set security_groups when create internal ports for nova server

    Make sure nova server be created in correct security groups
    if user specified subnet and security_groups when create/update
    server.

    Change-Id: Ic93cad4def90f3da25390d871d6a8c14ffe1c5ae
    Closes-Bug: #1571975
    (cherry picked from commit 66b6490705affa7e11b4fce43f8f1face9e8767b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 6.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 5.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 6.1.0 release.