[UI] does not display a custom message if 'action:none' option used

Bug #1571641 reported by Artem Savinov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Julia Aranovich
Mitaka
Fix Released
High
Vitaly Kramskikh

Bug Description

Detailed bug description:
In the environment_config.yml written restrictions with defined parameters 'action: none' and 'message'. Example:
    restrictions:
      - condition: 'settings:nsxv.nsxv_metadata_nova_client_priv_key.value.name != null and settings:nsxv.nsxv_metadata_nova_client_cert.value.name == null'
        action: 'none'
        strict: false
        message: 'If "Private key" loaded, also need load "Client certificate for nova metadata api server"'
 When restrictions triggered is not displayed custom message, example attached.

Steps to reproduce:
1) Install NSXv plugin in Fuel
2) Load "Client certificate for nova metadata api server" or "Private key" in "Network" tab -> "Network Settings" -> "Other" -> "NSXv plugin"
3) Move the mouse cursor on the yellow triangle

Expected results:
Showing a custom message.
Actual result:
Showing a "standard" message

Description of the environment:
Fuel #203
NSXv plugin used from https://review.openstack.org/#/c/306481/

Tags: area-ui
Revision history for this message
Artem Savinov (asavinov) wrote :
Changed in fuel:
status: New → Confirmed
assignee: nobody → Fuel UI Team (fuel-ui)
milestone: none → 9.0
Dmitry Klenov (dklenov)
tags: added: area-ui
Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Julia Aranovich (jkirnosova)
Changed in fuel:
milestone: 9.0 → 10.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/307845

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
importance: High → Medium
Changed in fuel:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/309337

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/307845
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=e487ce9aa2ca8b0e4b0a5e9b9e64f40c53b3f64a
Submitter: Jenkins
Branch: master

commit e487ce9aa2ca8b0e4b0a5e9b9e64f40c53b3f64a
Author: Julia Aranovich <email address hidden>
Date: Tue Apr 19 17:12:59 2016 +0300

    Fix layout of file input

    [type=file] input is hidden now by opacity:0 css style.
    But it still overlaps the input label and warning tooltip.
    This commit fixed this by hiding the input with display:none.

    Closes-Bug: #1571641

    Change-Id: Ia24586289c7fe775c6b052f390a99f6e774255a2

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/309337
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=f001c87b644ac581f76cf386ca8b4683e4b5e40b
Submitter: Jenkins
Branch: stable/mitaka

commit f001c87b644ac581f76cf386ca8b4683e4b5e40b
Author: Julia Aranovich <email address hidden>
Date: Tue Apr 19 17:12:59 2016 +0300

    Fix layout of file input

    [type=file] input is hidden now by opacity:0 css style.
    But it still overlaps the input label and warning tooltip.
    This commit fixed this by hiding the input with display:none.

    Closes-Bug: #1571641

    Change-Id: Ia24586289c7fe775c6b052f390a99f6e774255a2

tags: added: on-verification
Revision history for this message
Grigory Mikhailov (gmikhailov) wrote :

Verified on #fake-ui.
Custom message is still showed.

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.