Windows XP, cannot link rev 14858

[Alvin Penner]

using btool and devlibs 61, I get the following errors:

##### Target : link
##### link objects and library to create executable
--- link / rc
--- link / link
Make error line 460: LINK problem: build\obj\extension\plugins\grid2\grid.o:grid
.cpp:(.text+0x0): multiple definition of `Inkscape::Extension::Internal::Grid::l
oad(Inkscape::Extension::Extension*)'
build\obj\extension\internal\grid.o:grid.cpp:(.text+0x0): first defined here
build\obj\extension\plugins\grid2\grid.o:grid.cpp:(.text+0x18): multiple definit
ion of `Inkscape::Extension::Internal::Grid::prefs_effect(Inkscape::Extension::E
ffect*, Inkscape::UI::View::View*, sigc::signal<void, sigc::nil, sigc::nil, sigc
::nil, sigc::nil, sigc::nil, sigc::nil, sigc::nil>*, Inkscape::Extension::Implem
entation::ImplementationDocumentCache*)'
build\obj\extension\internal\grid.o:grid.cpp:(.text+0x18): first defined here
build\obj\extension\plugins\grid2\grid.o:grid.cpp:(.text+0x1c0): multiple defini
tion of `Inkscape::Extension::Internal::PrefAdjustment::val_changed()'
build\obj\extension\internal\grid.o:grid.cpp:(.text+0x19c): first defined here
build\obj\extension\plugins\grid2\grid.o:grid.cpp:(.text+0x200): multiple defini
tion of `Inkscape::Extension::Internal::Grid::effect(Inkscape::Extension::Effect
*, Inkscape::UI::View::View*, Inkscape::Extension::Implementation::Implementatio
nDocumentCache*)'
build\obj\extension\internal\grid.o:grid.cpp:(.text+0x208): first defined here
build\obj\inkscape-version.o:inkscape-version.cpp:(.data+0x0): multiple definiti
on of `Inkscape::version_string'
build\obj\extension\plugins\grid2\grid.o:grid.cpp:(.data+0x0): first defined her
e
collect2: ld returned 1 exit status

[Patrick Storz (ede123)]

Same issue with 64-bit builds on Windows 7 x64.

Caused by revision 14855
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14855

[jazzynico (jazzynico)]

Confirmed on Windows 7, Inkscape trunk rev. 14859 (32-bit devlibs).

[jazzynico (jazzynico)]

nm returns the following result:

$ nm build/obj/extension/plugins/grid2/grid.o |grep "version"
00000000 t __GLOBAL__sub_I__ZN8Inkscape14version_stringE
00000000 D __ZN8Inkscape14version_stringE

[theAdib (theadib)]

the src/extension/plugins/ stuff is the new feature of having c++ plugins linking against a inkscapebase.dll

btool currently does not create this dll.

So using btool this must be kept out of building.

The problem was a small typo in build-xx.xml
s/plugin/plugins/

please see attached patch and commit if appropriate. I am limited here commiting.

regards, Adib.
--

[jazzynico (jazzynico)]

Patch tested successfully on Windows 7, Inkscape trunk rev. 14859 (32-bit devlibs).
Thanks Adib!

[Alvin Penner (apenner)]

thanks, that fixed it for me too, on Windows XP

[theAdib (theadib)]

fix committed in rev 14860