Crash when EditBox text exceeds maximum width
Bug #1571308 reported by
Miroslav Remák
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
/home/miroslavr
This is reproducible with EditBoxes in the "Begin Network Game" menu (nickname & host) and 1024x768 resolution.
Related branches
lp:~widelands-dev/widelands/bug-1571308-fh1-texture-size
- Miroslav Remák: Approve (code)
-
Diff: 144 lines (+26/-6)6 files modifiedsrc/graphic/graphic.cc (+5/-3)
src/graphic/graphic.h (+5/-0)
src/graphic/text/rt_errors.h (+1/-0)
src/graphic/text/rt_render.cc (+8/-0)
src/ui_basic/editbox.cc (+5/-2)
src/ui_basic/multilineeditbox.cc (+2/-1)
lp:~widelands-dev/widelands/bug-1571308-editbox_crash
- GunChleoc: Approve
-
Diff: 274 lines (+37/-31)13 files modifiedsrc/editor/ui_menus/main_menu_map_options.cc (+2/-2)
src/editor/ui_menus/main_menu_random_map.cc (+2/-2)
src/editor/ui_menus/main_menu_save_map.cc (+1/-1)
src/editor/ui_menus/main_menu_save_map_make_directory.cc (+1/-1)
src/editor/ui_menus/player_menu.cc (+1/-1)
src/ui_basic/editbox.cc (+17/-15)
src/ui_basic/editbox.h (+4/-1)
src/ui_fsmenu/internet_lobby.cc (+1/-1)
src/ui_fsmenu/netsetup_lan.cc (+2/-2)
src/wui/building_statistics_menu.cc (+1/-1)
src/wui/game_main_menu_save_game.cc (+1/-1)
src/wui/gamechatpanel.cc (+1/-1)
src/wui/login_box.cc (+3/-2)
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| status: | New → Confirmed |
Revision history for this message
| Miroslav Remák (miroslavr256) wrote | #2 |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → GunChleoc (gunchleoc) |
| Changed in widelands: | |
| status: | In Progress → Confirmed |
| assignee: | GunChleoc (gunchleoc) → nobody |
| Changed in widelands: | |
| assignee: | nobody → Miroslav Remák (miroslavr256) |
| description: | updated |
| Changed in widelands: | |
| status: | Confirmed → Fix Committed |
| assignee: | Miroslav Remák (miroslavr256) → nobody |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
To post a comment you must log in.
This happens when the texture size for the text exceeds what GL can handle. I don't think many people will try to have that long a nick or host name, but we should cap this somehow.