Work area radius: 45xxxxxxx in bzr7962[trunk]

[Klaus Halfmann]

Some Buildings show
Work area radius: 459874944

I found: Ax Workshop, Smelting Works, Charcoal Kiln, War Mill,

Bakery shows: Work area radius: 456396352
Big Inn: 454954656
Brewery: 458567408
etc.

To test open the help with f1 and scroll tgrough the Buildings Help.

Perhaps this was introduced via som type changes for uint8 to uint32 / ResourceAmount
and some calculations based on these.

[Miroslav Remák (miroslavr256)]

These buildings don't have a work area. The problem is that LuaBuildingDescription::get_workarea_radius doesn't check for that case and dereferences an invalid iterator. It should push a nil onto the stack when no work area is available.

[kaputtnik (franku)]

For empire tribe the "workarea" isn't shown for such buildings. So i guess the culprit is somewhere in the Lua files?

[Miroslav Remák (miroslavr256)]

It's undefined whether it shows up or not. See my post. I don't think any Lua files are at fault here.

[Miroslav Remák (miroslavr256)]

Also see this condition:
      if(building_description.workarea_radius and building_description.workarea_radius > 0) then
         result = result .. text_line(_"Work area radius:", building_description.workarea_radius)
      end

[Klaus Halfmann (klaus-halfmann)]

Ill try to fix this on a local branch, but I go back to work next Monday,
so maybe I will not have enough time to fix this.

[GunChleoc (gunchleoc)]

Thanks for taking this on! If you don't manage to complete the fix and want somebody else to take over, you can push the branch and ping us in this bug.

[Klaus Halfmann (klaus-halfmann)]

Hello Miroslav:

I failed to find this condition
> if(building_description.workarea_radius and building_description.workarea_radius > 0) then
> result = result .. text_line(_"Work area radius:", building_description.workarea_radius)
 (This hould be some lua code?)

Can you point me to the sources, please?

[Miroslav Remák (miroslavr256)]

http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/data/tribes/scripting/help/building_help.lua#L229

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.