complicated wrong logic inside selenium wrapper _execute method

[Sergei Chipiga]

I found that method _execute inside horizon/tests/webdriver.py has complicated and wrong logic, that in race condition leads to long tests, for example we have tests with 10 min duration.

The core problem is that `while True` is used to wait for an element, but `implicit_wait` delegates this to browser already.
We need just to catch StaleElementRereferenceException, reload the chain of element's parents and then execute a command again.

[Timur Sufiev (tsufiev-x)]

Setting Importance to High since it is the root cause of intermittent test failures due to devstack job timeout.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306325
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=755d07cbdf66b2b01940dc2031692dce07c3e75b
Submitter: Jenkins
Branch: master

commit 755d07cbdf66b2b01940dc2031692dce07c3e75b
Author: Sergei Chipiga <email address hidden>
Date: Fri Apr 15 12:35:32 2016 +0300

    Fix longtime tests

    The core problem is in usage `while True:` to wait element,
    but implicit_wait delegates its to browser already.
    Just we need to catch StaleElement exception, reload
    chain of element parents and then to execute command again.

    Change-Id: I9c94b8adb04489c9675644d1501919af35e5bf99
    Closes-Bug: #1570803

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/307886

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/307886
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ec4fdd8a73c9c64a2d9fa93048301465ab8aea9f
Submitter: Jenkins
Branch: stable/mitaka

commit ec4fdd8a73c9c64a2d9fa93048301465ab8aea9f
Author: Sergei Chipiga <email address hidden>
Date: Fri Apr 15 12:35:32 2016 +0300

    Fix longtime tests

    The core problem is in usage `while True:` to wait element,
    but implicit_wait delegates its to browser already.
    Just we need to catch StaleElement exception, reload
    chain of element parents and then to execute command again.

    Change-Id: I9c94b8adb04489c9675644d1501919af35e5bf99
    Closes-Bug: #1570803
    (cherry picked from commit 755d07cbdf66b2b01940dc2031692dce07c3e75b)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 9.0.1 release.