Create Image: Redunant Error Message

[Diana Whitten]

admin/images: '+ Create Image' ... if you submit the form without filling out any required fields, proper form errors show but also a general 'alert' form error. This is redundant and not needed: https://i.imgur.com/NEOb77o.png

[Diana Whitten (hurgleburgler)]

Also on project/images

[Andy Hsiang (yh418t)]

Hi, the alert error message appeared due to not specify the image location while the inline warnings are for other default fields being empty. is this not expected behavior?

[Diana Whitten (hurgleburgler)]

Yes, but the form already says "this field required". So the alert is redundant information, since the form error supplies the same 'required' message.

[Andy Hsiang (yh418t)]

Hi Ankur, are you still working on this bug?

[Ankur (ankur-gupta-f)]

Hello Andy. I was not able to find a suitable solution. I will assign myself, please go ahead. Thank you

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/329609

[valw (valw)]

Fix proposed to branch: master
Review: https://review.openstack.org/329609/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329668

[OpenStack Infra (hudson-openstack)]

Change abandoned by valw (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/329609
Reason: Good catch. I will re-submit the change to master. Thank you.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329668
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=06e1272c7d52eb7d0de4d49737a22c65df5d4864
Submitter: Jenkins
Branch: master

commit 06e1272c7d52eb7d0de4d49737a22c65df5d4864
Author: Val W <email address hidden>
Date: Thu Jun 16 14:43:02 2016 +0000

    Relocated error message to associated field and corrected grammar

    Validation error was displaying at the top of the form making it
    seem as though it was a redundant error. Added validation so that
    error appears below the affected field. Fixed the grammar of the
    original error message (“a image” -> “an image”).

    Change-Id: I7250a44138a3559ddf39ff9d7bde1478ecb3a143
    Closes-Bug: 1570510

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/364717

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364717
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=196be9a9eb7c4f2c4944c7654814e75ee3552d12
Submitter: Jenkins
Branch: master

commit 196be9a9eb7c4f2c4944c7654814e75ee3552d12
Author: Kenji Ishii <email address hidden>
Date: Fri Sep 2 16:26:11 2016 +0900

    A follow up patch to #1570510

    The change of https://review.openstack.org/#/c/329668/
    is missing the viewpoint of translation.

    Change-Id: I0aecf9e0e54ea70d6d435f5a6a68a74575a7db42
    Related-Bug: #1570510