fixtures==2.0.0 breaks unittests for Nova in 8.0 branch

Bug #1569805 reported by Rodion Tikunov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
High
Rodion Tikunov

Bug Description

Confirmed on:
MOS 8.0

Issue:
CI tests gate-nova-python27 and gate-nova-python27-pkg-master for the nova failed up with "TypeError: fake_get() takes exactly 3 arguments (2 given)" message.
Looks like this is probably due to fixtures 2.0 released at 2016-04-07:
https://pypi.python.org/pypi/fixtures

Details:
http://logs.mosi.mirantis.net/75/19475/1/check/gate-nova-python27/51d5ec6/console.html
09:08:00 nova.tests.unit.api.openstack.compute.test_serversV21.ServersControllerRebuildInstanceTest.test_stop_not_ready
09:08:00 --------------------------------------------------------------------------------------------------------------
09:08:00
09:08:00 Captured traceback:
09:08:00 ~~~~~~~~~~~~~~~~~~~
09:08:00 Traceback (most recent call last):
09:08:00 File "nova/tests/unit/api/openstack/compute/test_serversV21.py", line 1781, in test_stop_not_ready
09:08:00 self.controller._stop_server, req, FAKE_UUID, body)
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 434, in assertRaises
09:08:00 self.assertThat(our_callable, matcher)
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 445, in assertThat
09:08:00 mismatch_error = self._matchHelper(matchee, matcher, message, verbose)
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 495, in _matchHelper
09:08:00 mismatch = matcher.match(matchee)
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/matchers/_exception.py", line 108, in match
09:08:00 mismatch = self.exception_matcher.match(exc_info)
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/matchers/_higherorder.py", line 62, in match
09:08:00 mismatch = matcher.match(matchee)
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 426, in match
09:08:00 reraise(*matchee)
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/matchers/_exception.py", line 101, in match
09:08:00 result = matchee()
09:08:00 File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 982, in __call__
09:08:01 return self._callable_object(*self._args, **self._kwargs)
09:08:01 File "nova/api/openstack/extensions.py", line 504, in wrapped
09:08:01 raise webob.exc.HTTPInternalServerError(explanation=msg)
09:08:01 webob.exc.HTTPInternalServerError: Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.
09:08:01 <type 'exceptions.TypeError'>
09:08:01
09:08:01
09:08:01 Captured pythonlogging:
09:08:01 ~~~~~~~~~~~~~~~~~~~~~~~
09:08:01 2016-04-11 09:02:23,324 ERROR [nova.api.openstack.extensions] Unexpected exception in API method
09:08:01 Traceback (most recent call last):
09:08:01 File "nova/api/openstack/extensions.py", line 478, in wrapped
09:08:01 return f(*args, **kwargs)
09:08:01 File "nova/api/openstack/compute/servers.py", line 1156, in _stop_server
09:08:01 instance = self._get_instance(context, id)
09:08:01 TypeError: fake_get() takes exactly 3 arguments (2 given)

Changed in mos:
milestone: none → 8.0-updates
assignee: nobody → Rodion Tikunov (rtikunov)
status: New → In Progress
importance: Undecided → High
Changed in mos:
milestone: 8.0-updates → 8.0-mu-1
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/nova (openstack-ci/fuel-8.0/liberty)

Reviewed: https://review.fuel-infra.org/19485
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: 54c3b3906dbfc66100865c462026461530c7ed42
Author: Rodion Tikunov <email address hidden>
Date: Wed Apr 13 10:36:04 2016

[8.0] change requirements for fixtures

New version of package fixtures==2.0.0 breaks unittests for 8.0. Pin its
version <2.0.0

Change-Id: I5b38ad17adc9566dc2f0bc7428b7935eb9e04c15
Closes-Bug: #1569805

Changed in mos:
status: In Progress → Fix Committed
tags: added: on-verification
tags: removed: on-verification
Changed in mos:
status: Fix Committed → Fix Released
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/nova (9.0/mitaka)

Fix proposed to branch: 9.0/mitaka
Change author: Rodion Tikunov <email address hidden>
Review: https://review.fuel-infra.org/20565

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/nova (9.0/mitaka)

Change abandoned by Roman Podoliaka <email address hidden> on branch: 9.0/mitaka
Review: https://review.fuel-infra.org/20565
Reason: Liberty specific, not needed for Mitaka (9.0)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.