noop tests check deprecated parameter "DEFAULT/notification_driver"

[Dmitry Burmistrov]

Detailed bug description:
 Current noop tests in fuel check deprecated parameter "DEFAULT/notification_driver". Upstream puppets are going to be changed with new "oslo_messaging_notifications/driver" parameter (patch example: https://review.openstack.org/#/c/302738/ - this patches switches puppet-keystone to use puppet-oslo with non-deprecated parameters). It affects "keystone" and "cinder":
  # fgrep -Rl 'DEFAULT/notification_driver' tests/noop/spec/hosts/
  tests/noop/spec/hosts/keystone/keystone_spec.rb
  tests/noop/spec/hosts/openstack-cinder/openstack-cinder_spec.rb
  tests/noop/spec/hosts/roles/cinder_spec.rb
Steps to reproduce:
 Run noop tests for keystone:
    - get patched puppet-keystone ( https://review.openstack.org/#/c/302738/ )
    - run noop tests, example: ./tests/noop/noop_tests.sh -b -s keystone/keystone -y neut_tun.ceph.murano.sahara.ceil-primary-controller -A -a
    - jenkins job: https://ci.fuel-infra.org/job/master.puppet-openstack.fuel.noop/95/consoleFull
Expected results:
 successful noop tests
Actual result:
 failed noop tests: failed should configure notification driver (expected that the catalogue would contain Keystone_config[DEFAULT/notification_driver])
Reproducibility:
 <put your information here>
Workaround:
 comment tests with deprecated "DEFAULT/notification_driver" or use modern "oslo_messaging_notifications/driver" in tests
Impact:
 keystone and cinder related tests may fail
Description of the environment:
 Operation system: Ubuntu 14.04
 Versions of components: -
 Reference architecture: -
 Network model: -
 Related projects installed: -
Additional information:
 We should migrate to "oslo_messaging_notifications/driver"

[Ivan Berezovskiy (iberezovskiy)]

Aodh noop tested are also affected:

FAILED aodh/aodh ubuntu neut_tun.ceph.murano.sahara.ceil-controller

failed should configure "DEFAULT/" section (expected that the catalogue would contain aodh_config[DEFAULT/notification_topics])

Parameter was changed to oslo_messaging_notifications/topics.

Set status to critical because noop tests for fuel-library are failing right now

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304036
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=6609d03eced8522eb7d78384ce8a79c31efac759
Submitter: Jenkins
Branch: master

commit 6609d03eced8522eb7d78384ce8a79c31efac759
Author: dmburmistrov <email address hidden>
Date: Mon Apr 11 14:03:51 2016 +0300

    Disable tests for deprecated notification* parameters

    Upstream modules are switching to use oslo
    resources. Oslo module configures non-deprecated
    parameter "oslo_messaging_notifications/driver"
    and "oslo_messaging_notifications/topics"
    To prevent noop-test failures these tests are
    commented out. Also this patch overrides
    old parameters to check with non-deprecated
    "oslo_messaging_notifications" section.

    Closes-bug: #1568796

    Change-Id: I6b27f883d5eb07d3876e90e52a0880c5feb28054

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/309370

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309370
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e51623c6bf694c93e5912f1a7b9b924707526eb0
Submitter: Jenkins
Branch: master

commit e51623c6bf694c93e5912f1a7b9b924707526eb0
Author: iberezovskiy <email address hidden>
Date: Wed Apr 20 19:45:13 2016 +0300

    Updates for notification_driver parameters of some services

    * don't hard-code notification driver for heat and murano
    * accordingly update yaql expressions in tasks.yaml
    * enable previously disabled tests because of upstream work

    Change-Id: Id6d6a9a2308e716d030989944dd951cc7301751c
    Related-bug: #1566716
    Related-bug: #1568796

[Ivan Berezovskiy (iberezovskiy)]

Confirmed for 9.1 because of https://review.openstack.org/#/c/334845. Our noop tests for stable/mitaka are checking old value - https://github.com/openstack/fuel-library/blob/stable/mitaka/tests/noop/spec/hosts/openstack-cinder/openstack-cinder_spec.rb#L198-L204. Need to disable this test and enable it later if we are going to update tag for puppet-cinder module.

[Ivan Berezovskiy (iberezovskiy)]

This bug doesn't really affect deployment, this change is required to keep our tests under puppet modules green in upstream. It will be required for fuel if we update tag for puppet-cinder module

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/344876

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/344876
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b36375f4e57cb58aff504c1598ce5dd43f96cf4a
Submitter: Jenkins
Branch: stable/mitaka

commit b36375f4e57cb58aff504c1598ce5dd43f96cf4a
Author: iberezovskiy <email address hidden>
Date: Wed Jul 20 17:46:54 2016 +0300

    Temprorary disable test for cinder notification dirver

    It's required to disable this test to keep our jobs green
    for OpenStack puppet modules. Issue was found in
    https://review.openstack.org/#/c/334845/.
    Uncomment this test if we update tag for puppet-cinder module.

    Change-Id: I15f8a5a597ba6521b3c6953fdafe1e1716f06e13
    Closes-bug: #1568796

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/345878

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345878
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=84da7c699eea9cc1393003b70a792d2416f3e7fd
Submitter: Jenkins
Branch: stable/mitaka

commit 84da7c699eea9cc1393003b70a792d2416f3e7fd
Author: iberezovskiy <email address hidden>
Date: Fri Jul 22 10:35:47 2016 +0300

    Temprorary disable test for cinder notification dirver

    https://review.openstack.org/#/c/344876/ misses changes for
    roles/cinder. This patch adds it.

    Change-Id: Ie0be7fbea9f3373985db1494922186673bf4386d
    Closes-bug: #1568796

[Kristina Berezovskaia (kkuznetsova)]

Noop-test was disabled but it wasn't turned on after fixing bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/356470

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/356470
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=c07d5f9f1e36d5f5ede74c5caa8236fc6b54707b
Submitter: Jenkins
Branch: stable/mitaka

commit c07d5f9f1e36d5f5ede74c5caa8236fc6b54707b
Author: iberezovskiy <email address hidden>
Date: Wed Aug 17 16:35:45 2016 +0300

    Re-enable notification_drvier test for cinder

    Upstream patch (https://review.openstack.org/#/c/334845) is merged,
    puppet-cinder tag is updated to 8.2.0 (which includes this patch),
    so notification_drvier test for cinder could be enabled back.

    Change-Id: I8856414c3b3c61b7d99d5295507e17ec4c3e02ba
    Closes-bug: #1568796