Overriding savegames on OSX with --nozip fails

[Klaus Halfmann]

If I try to override a map on OSX when calling widelands with the --nozip option I get

Error saving the game, the Map may be broken (actually German
"Fehler beim Speichern der Karte!
Die gespeocherte karte ist evtl. beschädigt!"

Grund: src/io/filesystem/disk_fil...
DiskFileSystem: unable to rename ... to ... Directory not empty
"
Got no logs for this, mmh.

On the disk I then find...
10 Apr 16:44 all_types.wmf
10 Apr 17:11 all_types.wmf.tmp

Ther Windows is actually to small for the Error-Message

[GunChleoc (gunchleoc)]

We have the same problem for the zip filesystem in Windows:

https://bugs.launchpad.net/widelands/+bug/1548932

We originally introduced the temp tile and the moving to prevent the script subdirectory from being deleted.

https://bugs.launchpad.net/widelands/+bug/1375915

I am wondering if we should find a different fix for the original bug.

[Miroslav Remák (miroslavr256)]

Here's a summary of what happens when you overwrite the map:
1. "all_types.wmf.tmp" is created
2. "all_types.wmf" is removed
3. "all_types.wmf.tmp" is renamed to "all_types.wmf"

Sounds like step 2 is failing here (and consequently also step 3). Could be due to wrong permissions or hidden files within the "all_types.wmf" directory.

Can you run:
 ls -Ral all_types.wmf/

Also, is "all_types.wmf.tmp" removed when you click OK after the error message shows up?

[GunChleoc (gunchleoc)]

Does this still happen in r8004?

[Klaus Halfmann (klaus-halfmann)]

Tested this with an almost empty Map in bzr8005[trunk]

 MapSaver::save() for 'Test1568540' took 97ms
 MapSaver::save() for 'Test1568540' took 8ms

Looks ok on disk:

Test1568540.wmf klaus$ ls -l
total 56
drwxr-xr-x 6 klaus staff 204 17 Mai 18:55 binary
-rw-r--r-- 1 klaus staff 204 17 Mai 18:55 elemental
-rw-r--r-- 1 klaus staff 318 17 Mai 18:55 minimap.png
-rw-r--r-- 1 klaus staff 89 17 Mai 18:55 objective
-rw-r--r-- 1 klaus staff 158 17 Mai 18:55 player_names
-rw-r--r-- 1 klaus staff 106 17 Mai 18:55 player_position
-rw-r--r-- 1 klaus staff 130 17 Mai 18:55 port_spaces
drwxr-xr-x 2 klaus staff 68 17 Mai 18:55 scripting
-rw-r--r-- 1 klaus staff 259 17 Mai 18:55 version

OK for me. Perhaps someone on Linux should test this, too?

[GunChleoc (gunchleoc)]

No issues on Linux.

BTW only set a bug to "In Progress" when you're actually doing some coding ;)

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.