Redeploy takes too much time

[Stanislaw Bogatkin]

Current Fuel master (tested on 10.0 #69 ISO).

Scenario:
1. Create an env. Add one controller, one compute.
2. Deploy it.
3. Add one more compute.
4. Deploy it.

Second deployment ask all nodes to redeploy (and old compute and controller too) and it takes really long time - up to 50 minutes on my machine. But we really need only some of tasks on old nodes to run, moreover - some tasks on controller (like rabbitmq one) completely blocks all tasks on other nodes, so we need to wait 5-10 minutes for task which do nothing.

Proposal - create some conditions for task running such a way so it won't run unneeded tasks to run.

[Stanislaw Bogatkin (sbogatkin)]

Addressed by https://review.openstack.org/#/c/298341/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/304065

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/298341
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b64d085d61ab1c98e252293edfdb0051ae4bc7aa
Submitter: Jenkins
Branch: master

commit b64d085d61ab1c98e252293edfdb0051ae4bc7aa
Author: Stanislaw Bogatkin <email address hidden>
Date: Mon Mar 28 20:23:50 2016 +0300

    Move conditions in tasks to YAQL

    As new serializer was introduced in nailgun and it is allow to run
    a task on custom condition - move some tasks to use those conditions
    to better handle redeployment cases.

    This patch includes fixes for

    * most of common tasks
    * most of controller tasks
    * compute tasks

    Closes-Bug: #1567424
    Change-Id: I3401e3127efc3e0c9ebc1be30f5f097575ca5890
    DocImpact

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/308891

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308891
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b676aa0325bb38288c8e5d337b13d70be8ad636e
Submitter: Jenkins
Branch: stable/mitaka

commit b676aa0325bb38288c8e5d337b13d70be8ad636e
Author: Stanislaw Bogatkin <email address hidden>
Date: Mon Mar 28 20:23:50 2016 +0300

    Move conditions in tasks to YAQL

    As new serializer was introduced in nailgun and it is allow to run
    a task on custom condition - move some tasks to use those conditions
    to better handle redeployment cases.

    This patch includes fixes for

    * most of common tasks
    * most of controller tasks
    * compute tasks

    Closes-Bug: #1567424
    Change-Id: I3401e3127efc3e0c9ebc1be30f5f097575ca5890
    DocImpact
    (cherry picked from commit b64d085d61ab1c98e252293edfdb0051ae4bc7aa)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/309478

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309478
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=df8d91b1095e12f0357a86d830a74af30ce7e5e9
Submitter: Jenkins
Branch: master

commit df8d91b1095e12f0357a86d830a74af30ce7e5e9
Author: Matthew Mosesohn <email address hidden>
Date: Fri Apr 22 18:53:58 2016 +0300

    Fix indentation on aodh task

    Change-Id: I551ffaec42c7a1d4a995c1eec4e8cc111c02f140
    Related-Bug: #1567424

[Ksenia Svechnikova (kdemina)]

Reproducible: 100% on ISO

     fuel-9.0-234 up to fuel-9.0-242

Steps to reproduce:
Deploy cluster in HA mode with 3 controller

            1. Create cluster
            2. Add 3 node with controller and mongo roles
            3. Add 2 node with compute and cinder roles
            4. Deploy the cluster

Actual result:
AssertionError: Task 'deploy' has incorrect status. error != ready, 'Deployment has failed. All nodes are finished. Failed tasks: Task[aodh/1], Task[aodh/2], Task[aodh/4] Stopping the deployment process!'

https://product-ci.infra.mirantis.net/view/9.0_swarm/job/9.0.system_test.ubuntu.cic_maintenance_mode/88/console

[Ksenia Svechnikova (kdemina)]

Please update the status back to Fix comitted, when https://review.openstack.org/#/c/309478/1 will be merged

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/309905

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309905
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=6a95042689a4af4eb21b8c4e800191be0a52f2fc
Submitter: Jenkins
Branch: stable/mitaka

commit 6a95042689a4af4eb21b8c4e800191be0a52f2fc
Author: Matthew Mosesohn <email address hidden>
Date: Fri Apr 22 18:53:58 2016 +0300

    Fix indentation on aodh task

    Change-Id: I551ffaec42c7a1d4a995c1eec4e8cc111c02f140
    Related-Bug: #1567424
    (cherry picked from commit df8d91b1095e12f0357a86d830a74af30ce7e5e9)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/310226

[Stanislaw Bogatkin (sbogatkin)]

RCA: all tasks were redeployed, cause we didn't have proper conditions for them.

[Stanislaw Bogatkin (sbogatkin)]

RCA also included: missed functionality of a new feature.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310226
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ec782fefcd403c9973cecd313424326d84544410
Submitter: Jenkins
Branch: stable/mitaka

commit ec782fefcd403c9973cecd313424326d84544410
Author: Stanislaw Bogatkin <email address hidden>
Date: Wed Apr 20 18:35:20 2016 +0300

    Move all remaining tasks conditions to yaql

    This patch creates yaql conditions for all tasks which previously
    didn't have it.

    Change-Id: I9c50339474e84faa644cfe652a4d014b1ada2101
    Partial-Bug: #1567424
    (cherry picked from commit f1c1200d7bdeca7e8c892ae368bc84d068e4f434)

[Tatyanka (tatyana-leontovich)]

verified on 285 iso run for mitaka

[Dmitry Belyaninov (dbelyaninov)]

Verified on Newton #1570 iso.