no warning message for empty username with inline user edit

Bug #1567398 reported by Sergei Chipiga
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Gregory Hooks

Bug Description

Environment:
- upstream
- Chrome, Firefox

Steps:
- Login as admin
- Go to "Identity" -> "Users"
- Move cursor to username and click icon "edit"
- Clear username field and click icon "save"

Expected result:
- Warning message that username can't be empty

Actual result:
- No notifications. Just username is still in edit mode

description: updated
description: updated
Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
milestone: none → next
Andy Hsiang (yh418t)
Changed in horizon:
assignee: nobody → Andy Hsiang (yh418t)
Andy Hsiang (yh418t)
Changed in horizon:
assignee: Andy Hsiang (yh418t) → nobody
Changed in horizon:
assignee: nobody → Gregory Hooks (gregoryhooksjr)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Gregory Hooks (gregoryhooksjr) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/306675
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=af0d4dab7810e410560b1854ebf8db1188dab2e6
Submitter: Jenkins
Branch: master

commit af0d4dab7810e410560b1854ebf8db1188dab2e6
Author: Gregory Hooks <email address hidden>
Date: Sat Apr 16 01:34:13 2016 +0000

    Added a warning message if User Name is empty

    Adding required=False to the user name form allows it to call
    update_cell when it has been left empty. I added logic to update_cell
    to check if the form is empty or contains only whitespace and issue a
    warning if true and only if the form in question is called 'name'.

    Change-Id: Ieccb3f6d7be1acb4b7734e68d467a40cfc7eb99c
    Closes-Bug: 1567398

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → newton-1
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.