Update help text for [ml2] path_mtu

Bug #1566706 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Ihar Hrachyshka

Bug Description

This help message is not optimal and overloaded with details. While at it, physnet_mtus option refers to segment_mtu that does not even exist anymore since Mitaka.

tags: added: deprecation
Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/302089

Doug Wiegley (dougwig)
Changed in neutron:
status: New → Triaged
importance: Undecided → Medium
milestone: none → newton-1
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote : Re: Deprecate [ml2] path_mtu in favour of [DEFAULT] global_physnet_mtu

There are use cases to set path_mtu different from global_physnet_mtu (even if not common).

Changed in neutron:
status: Triaged → Invalid
summary: - Deprecate [ml2] path_mtu in favour of [DEFAULT] global_physnet_mtu
+ Update help text for [ml2] path_mtu in favour of [DEFAULT]
+ global_physnet_mtu
summary: - Update help text for [ml2] path_mtu in favour of [DEFAULT]
- global_physnet_mtu
+ Update help text for [ml2] path_mtu
description: updated
Changed in neutron:
status: Invalid → Confirmed
status: Confirmed → In Progress
tags: added: usability
removed: deprecation
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/302089
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=403e5a07f51dee1efd335011cdd6b4454d1e7fde
Submitter: Jenkins
Branch: master

commit 403e5a07f51dee1efd335011cdd6b4454d1e7fde
Author: Ihar Hrachyshka <email address hidden>
Date: Wed Apr 6 10:05:13 2016 +0200

    Fixed help messages for path_mtu and global_physnet_mtus options

    For path_mtu, make it clear it applies to tunnel typed tenant networks.
    Removed information about specific mechanisms used to advertise MTU
    values to instances because a) it duplicates the global_physnet_mtu
    option description; b) it is not complete now that we also advertise MTU
    via RAs. Finally, removed description for calculation details because
    they duplicate global_physnet_mtu description.

    While at it, fixed help text for global_physnet_mtus option not to refer
    to segment_mtu which was renamed into global_physnet_mtu lately.

    Change-Id: Ib0010206f08ec9a76b0e26e84cdb03c80755908d
    Related-Bug: #1566706

tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/322787

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/322787
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bd8adf3ee004d8155686ec05c18b31c3b9359c80
Submitter: Jenkins
Branch: stable/mitaka

commit bd8adf3ee004d8155686ec05c18b31c3b9359c80
Author: Ihar Hrachyshka <email address hidden>
Date: Wed Apr 6 10:05:13 2016 +0200

    Fixed help messages for path_mtu and global_physnet_mtus options

    For path_mtu, make it clear it applies to tunnel typed tenant networks.
    Removed information about specific mechanisms used to advertise MTU
    values to instances because a) it duplicates the global_physnet_mtu
    option description; b) it is not complete now that we also advertise MTU
    via RAs. Finally, removed description for calculation details because
    they duplicate global_physnet_mtu description.

    While at it, fixed help text for global_physnet_mtus option not to refer
    to segment_mtu which was renamed into global_physnet_mtu lately.

    The cherry-pick differs from the master patch, as Mitaka still uses
    a default value of 1500 for path_mtu. Master uses 0. The effect is,
    that with Mitaka you have to override the default 1500 path_mtu
    value to use jumbo frames, while with master the default 0 value is
    being ignored. There it's sufficient to specify the global_physnet_mtu
    only.

    Change-Id: Ib0010206f08ec9a76b0e26e84cdb03c80755908d
    Related-Bug: #1566706
    (cherry picked from commit 403e5a07f51dee1efd335011cdd6b4454d1e7fde)

tags: added: in-stable-mitaka
Changed in neutron:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/329782

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/329782
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f9d5064c22f07ca5df94deb9f2c1f5dfb2c6ba66
Submitter: Jenkins
Branch: stable/mitaka

commit f9d5064c22f07ca5df94deb9f2c1f5dfb2c6ba66
Author: Andreas Scheuring <email address hidden>
Date: Wed Jun 15 09:08:30 2016 +0200

    Fixed help messages for path_mtu and global_physnet_mtus options

    Giving better recommendations for meaningful values.

    Change-Id: Iea4a343465f06ba19fc8e504fc0ca329a718a8c5
    Related-Bug: #1566706

tags: removed: neutron-proactive-backport-potential
Changed in neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.