Add prechecks to validate kolla_internal_vip_address and kolla_external_vip_address

[Vikram Hosakote]

Many users see deployment issues because their kolla_internal_vip_address will not be an unused IP address in the same network as network_interface in globals.yml.

For example, if network_interface in globals.yml is eth0, and if eth0 has the IP address 192.168.122.201/24, then, kolla_internal_vip_address in globals.yml must be an unused IP address in the network 192.168.122.201/24 (192.168.122.202 - 192.168.122.254). There is no precheck for this.

Hence, prechecks must be added to check the following:

1. kolla_internal_vip_address cannot be pinged from any node.

1. kolla_external_vip_address cannot be pinged from any node.

3. When kolla_internal_vip_address is not a link-local address (i.e., not in the range 169.254.0.0/16), kolla_internal_vip_address is in the same network as network_interface on all nodes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302026

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/302026
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=1c0dcd8ba83aae488e855b371707349451a4e85f
Submitter: Jenkins
Branch: master

commit 1c0dcd8ba83aae488e855b371707349451a4e85f
Author: Vikram Hosakote <email address hidden>
Date: Wed Apr 6 03:35:22 2016 +0000

    Add prechecks to validate kolla_internal_vip_address and
    kolla_external_vip_address

    Change-Id: I4bd3b4283b85bd675927b9a54d6906bb3c0d668e
    Closes-Bug: #1566571

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/303938

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/303938
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=850213827bbd1181dbb588e3e18752648fb02a86
Submitter: Jenkins
Branch: stable/mitaka

commit 850213827bbd1181dbb588e3e18752648fb02a86
Author: Vikram Hosakote <email address hidden>
Date: Wed Apr 6 03:35:22 2016 +0000

    Add prechecks to validate kolla_internal_vip_address and
    kolla_external_vip_address

    Change-Id: I4bd3b4283b85bd675927b9a54d6906bb3c0d668e
    Closes-Bug: #1566571
    (cherry picked from commit 1c0dcd8ba83aae488e855b371707349451a4e85f)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/kolla 2.0.0.0rc4 release candidate.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 2.0.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 1.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.