'--version' shouldn't be used as an argument for subcommands

Bug #1565775 reported by Andrey Pavlov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Python client library for Sahara
Fix Released
High
Denis Egorenko
Mitaka
Fix Released
High
Vitalii Gridnev

Bug Description

"--version" is a global argument that shouldn't be used as an argument for commands and subcommands because even if it will be overridden, command will end with printing openstackclient version.

Example:

openstack dataprocessing node group template create --name ng-template-grenade --flavor 2cc63f47-f0be-40bc-a101-44ef72e53083 --plugin fake --version 0.1 --processes jobtracker namenode tasktracker datanode --floating-ip-pool public --auto-security-group

openstack 2.2.0

However it works fine in interactive mode.

Tags: cli
Changed in python-saharaclient:
importance: Undecided → High
Revision history for this message
Denis Egorenko (degorenko) wrote :
Changed in python-saharaclient:
status: New → In Progress
assignee: nobody → Denis Egorenko (degorenko)
Changed in python-saharaclient:
milestone: none → 0.13.0
milestone: 0.13.0 → none
milestone: none → 0.15.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-saharaclient (master)

Reviewed: https://review.openstack.org/323364
Committed: https://git.openstack.org/cgit/openstack/python-saharaclient/commit/?id=f02ea8999c79ea9a3e1f515220775bc54838f9d2
Submitter: Jenkins
Branch: master

commit f02ea8999c79ea9a3e1f515220775bc54838f9d2
Author: Denis Egorenko <email address hidden>
Date: Tue May 31 16:21:31 2016 +0300

    Change plugin version 'version' parameter to 'plugin-version'

    Currently we have parameter 'version' for specifying plugin version
    for creating node group templates and also for listing available
    plugins. The problem is that this parameter is global parameter for
    getting version of client. So, this patch fixes this confusion.

    Change-Id: I89a670188c20e3b20b98b596a3efb8d5997c3214
    Closes-bug: #1565775

Changed in python-saharaclient:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/python-saharaclient 0.15.0

This issue was fixed in the openstack/python-saharaclient 0.15.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-saharaclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/341312

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-saharaclient (stable/mitaka)

Reviewed: https://review.openstack.org/341312
Committed: https://git.openstack.org/cgit/openstack/python-saharaclient/commit/?id=9ad355705e4d9deb89cd6f399c71761b3ce1149d
Submitter: Jenkins
Branch: stable/mitaka

commit 9ad355705e4d9deb89cd6f399c71761b3ce1149d
Author: Denis Egorenko <email address hidden>
Date: Tue May 31 16:21:31 2016 +0300

    Change plugin version 'version' parameter to 'plugin-version'

    Currently we have parameter 'version' for specifying plugin version
    for creating node group templates and also for listing available
    plugins. The problem is that this parameter is global parameter for
    getting version of client. So, this patch fixes this confusion.

    Change-Id: I89a670188c20e3b20b98b596a3efb8d5997c3214
    Closes-bug: #1565775
    (cherry picked from commit f02ea8999c79ea9a3e1f515220775bc54838f9d2)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/python-saharaclient 0.14.1

This issue was fixed in the openstack/python-saharaclient 0.14.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/python-saharaclient 0.14.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.