BGPaaS: client router object not created sometimes on schema restart

[amit surana]

30 BGPaaS objects were created. All of them had their respective bgpaas-client/server router objects created correctly. However, upon schema restart, less than 50% of the client/server-router objects are recreated. Restarting ST again, will re-create all the bgpaas-client/server router objects (next restart again causes the bug).

Same test was done earlier (couple months back) with 100 BGPaaS objects, but similar issues weren't seen.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19014
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19015
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19014
Committed: http://github.org/Juniper/contrail-controller/commit/43f3f1079d9342f9805e91ac96a4ce2b9b79e28a
Submitter: Zuul
Branch: master

commit 43f3f1079d9342f9805e91ac96a4ce2b9b79e28a
Author: Sachin Bansal <email address hidden>
Date: Fri Apr 1 17:20:47 2016 -0700

bgpaas_clients dict is indexed by vmi fq_name

bgpaas_clients dict is indexed by vmi fq name, but during reinit,
we were indexing it incorrectly by vmi/router name. This causes
the bgp router to get deleted during re-evaluation.

Change-Id: I574780b6830f689937114b62dc0ca9357930f8bb
Closes-Bug: 1565153

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19015
Committed: http://github.org/Juniper/contrail-controller/commit/801084509e24392adde8c6bdbfb4ef331637b39b
Submitter: Zuul
Branch: R3.0

commit 801084509e24392adde8c6bdbfb4ef331637b39b
Author: Sachin Bansal <email address hidden>
Date: Fri Apr 1 17:20:47 2016 -0700

bgpaas_clients dict is indexed by vmi fq_name

bgpaas_clients dict is indexed by vmi fq name, but during reinit,
we were indexing it incorrectly by vmi/router name. This causes
the bgp router to get deleted during re-evaluation.

Change-Id: I574780b6830f689937114b62dc0ca9357930f8bb
Closes-Bug: 1565153
(cherry picked from commit 43f3f1079d9342f9805e91ac96a4ce2b9b79e28a)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19603
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19604
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19603
Committed: http://github.org/Juniper/contrail-controller/commit/e877722273d0fa17a7f9baa9f5f437e54431fdd8
Submitter: Zuul
Branch: master

commit e877722273d0fa17a7f9baa9f5f437e54431fdd8
Author: Sachin Bansal <email address hidden>
Date: Mon Apr 25 09:43:38 2016 -0700

Fixed the usage of member variable

Change-Id: Id578cc6374f2be97ea67635adbdcf8f33a4d5e74
Closes-Bug: 1565153

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19604
Committed: http://github.org/Juniper/contrail-controller/commit/afbead3cd1eaed0f1c89edfc10637102fbe7d06b
Submitter: Zuul
Branch: R3.0

commit afbead3cd1eaed0f1c89edfc10637102fbe7d06b
Author: Sachin Bansal <email address hidden>
Date: Mon Apr 25 09:43:38 2016 -0700

Fixed the usage of member variable

Change-Id: Id578cc6374f2be97ea67635adbdcf8f33a4d5e74
Closes-Bug: 1565153
(cherry picked from commit e877722273d0fa17a7f9baa9f5f437e54431fdd8)