[Patch] Convert all JSON modules to JSON::MaybeXS instead of discouraged JSON modules

Bug #1565017 reported by Shlomi Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Shutter
Fix Released
Undecided
Unassigned

Bug Description

Hi all! Thanks for shutter. This patch against the bzr version (which is also untested because I could not find an easy way to install shutter from the repo - there should be) converts shutter away from JSON::XS and JSON.pm to JSON::MaybeXS - see https://metacpan.org/pod/Perl::Critic::Policy::Freenode::DiscouragedModules . Please consider testing it and applying it.

Revision history for this message
Shlomi Fish (shlomif-gmail) wrote :
Revision history for this message
Shlomi Fish (shlomif-gmail) wrote :

Ping! Anyone cares to apply this patch?

Revision history for this message
Michael Kogan (michael-kogan) wrote :

Sorry for the late reply! Unfortunately, the patch doesn't apply cleanly to the latest revision. I will have a look and try to adjust it in a week. See also https://bugs.launchpad.net/shutter/+bug/1710398

Revision history for this message
Shlomi Fish (shlomif-gmail) wrote :

Here is a New patch. Please apply as soon as humanly possible.

Revision history for this message
Michael Kogan (michael-kogan) wrote :

Not as fast as humanly possible but at least at some point. :) Thanks for the updated patch!

Changed in shutter:
status: New → Fix Committed
Revision history for this message
Shlomi Fish (shlomif-gmail) wrote :

Thanks!

Changed in shutter:
milestone: none → 0.94.1
Changed in shutter:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.