juju-core

juju 1.25 -- go 1.6 -- provider/joyent tests explode due to incorrect use of AddCleanup

Bug #1564700 reported by Dave Cheney on 2016-04-01

6

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	juju-core	Fix Released	Undecided	Dave Cheney	juju-core 1.25.5

Bug Description

Blocks investigation of LP 1554251

+ set -e
+ go test -v -c -race
+++ pwd
++ basename /home/dfc/src/github.com/juju/juju/provider/joyent
+ PKG=joyent
+ true
+ env GOMAXPROCS=20 ./joyent.test

----------------------------------------------------------------------
PANIC: <autogenerated>:152: InternalSuite.SetUpSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:135
  in FakeJujuHomeSuite.SetUpSuite
<autogenerated>:152
  in InternalSuite.SetUpSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: <autogenerated>:154: InternalSuite.TearDownSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:139
  in FakeJujuHomeSuite.TearDownSuite
<autogenerated>:154
  in InternalSuite.TearDownSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: config_test.go:53: ConfigSuite.SetUpSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:135
  in FakeJujuHomeSuite.SetUpSuite
config_test.go:54
  in ConfigSuite.SetUpSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: <autogenerated>:2: ConfigSuite.TearDownSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:139
  in FakeJujuHomeSuite.TearDownSuite
<autogenerated>:2
  in ConfigSuite.TearDownSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: <autogenerated>:113: providerSimpleSuite.SetUpSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:135
  in FakeJujuHomeSuite.SetUpSuite
<autogenerated>:113
  in providerSimpleSuite.SetUpSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: <autogenerated>:115: providerSimpleSuite.TearDownSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:139
  in FakeJujuHomeSuite.TearDownSuite
<autogenerated>:115
  in providerSimpleSuite.TearDownSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: storage_test.go:36: storageSuite.SetUpSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:135
  in FakeJujuHomeSuite.SetUpSuite
joyent_test.go:62
  in providerSuite.SetUpSuite
storage_test.go:37
  in storageSuite.SetUpSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: storage_test.go:43: storageSuite.TearDownSuite

... Panic: runtime error: invalid memory address or nil pointer dereference (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/go/src/runtime/panic.go:62
  in panicmem
/home/dfc/go/src/runtime/sigpanic_unix.go:24
  in sigpanic
local_test.go:88
  in localMantaServer.destroyServer
storage_test.go:44
  in storageSuite.TearDownSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: local_test.go:150: localServerSuite.SetUpSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:135
  in FakeJujuHomeSuite.SetUpSuite
joyent_test.go:62
  in providerSuite.SetUpSuite
local_test.go:151
  in localServerSuite.SetUpSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: <autogenerated>:31: localServerSuite.TearDownSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:139
  in FakeJujuHomeSuite.TearDownSuite
joyent_test.go:67
  in providerSuite.TearDownSuite
<autogenerated>:31
  in localServerSuite.TearDownSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: local_test.go:99: localLiveSuite.SetUpSuite

... Panic: unsafe to call AddCleanup before SetUpSuite (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/src/github.com/juju/testing/cleanup.go:70
  in CleanupSuite.AddCleanup
/home/dfc/src/github.com/juju/testing/home.go:118
  in FakeHomeSuite.SetUpTest
/home/dfc/src/github.com/juju/juju/testing/environ.go:135
  in FakeJujuHomeSuite.SetUpSuite
joyent_test.go:62
  in providerSuite.SetUpSuite
local_test.go:100
  in localLiveSuite.SetUpSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit

----------------------------------------------------------------------
PANIC: local_test.go:115: localLiveSuite.TearDownSuite

... Panic: runtime error: invalid memory address or nil pointer dereference (PC=0x457C0E)

/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/runtime/panic.go:458
  in gopanic
/home/dfc/go/src/runtime/panic.go:62
  in panicmem
/home/dfc/go/src/runtime/sigpanic_unix.go:24
  in sigpanic
local_test.go:61
  in localCloudAPIServer.destroyServer
local_test.go:118
  in localLiveSuite.TearDownSuite
/home/dfc/go/src/runtime/asm_amd64.s:479
  in call32
/home/dfc/go/src/reflect/value.go:302
  in Value.Call
/home/dfc/go/src/runtime/asm_amd64.s:2013
  in goexit
OOPS: 6 passed, 12 FIXTURE-PANICKED, 49 MISSED
--- FAIL: TestJoyent (0.06s)
FAIL

Dave Cheney (dave-cheney) on 2016-04-01

Changed in juju-core:
milestone:	none → 1.25.5
status:	New → In Progress
assignee:	nobody → Dave Cheney (dave-cheney)

Dave Cheney (dave-cheney) on 2016-04-05

Changed in juju-core:
status:	In Progress → Fix Committed

Curtis Hovey (sinzui) on 2016-04-06

Changed in juju-core:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.