gateway_device should be blocked on deletion if any l2gateway is related to the gateway_device.

[Kengo Hobo]

gateway_device should be blocked on deletion if any l2gateway is related to the gateway_device.

However, in current implementaion, gateway_device cannot be deleted if router that is specified in resource_id has any ports.
Thus, even though there is no l2gateways that is related to the gateway_device,
deleting gateway_device is failed if the router has ports(e.g. uplink port).

Though there is no influence to user communication,
the validation is not proper, I think.

[YAMAMOTO Takashi (yamamoto)]

you mean that "gateway_device cannot be deleted" is the current state and
"Deleting gateway_device should be blocked" is the desirable one?
i don't understand the difference.

[Kengo Hobo (hobo-kengo)]

Difference between two description is condition for blocking deletion.
Current:
block deletion when there is no router port of backend router.

Proper:
block deletion when there is no l2gateway that related to the gateway_device.

[YAMAMOTO Takashi (yamamoto)]

i got it. thank you for explanation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/300567

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/300567
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=cb81f20dabab3d421df395066f241da6e5d33e5d
Submitter: Jenkins
Branch: master

commit cb81f20dabab3d421df395066f241da6e5d33e5d
Author: HoboK <email address hidden>
Date: Fri Apr 1 16:23:31 2016 +0000

    Change validation logic from router port to l2gateway in gateway_device deletion

    Change-Id: Ia73ca62f2e6e9ff00e0fde27d9f80a40bd79c2ae
    Closes-Bug: #1564228