cleanup upload_glance workarounds that were added when debugging CI issues

[Alex Schultz]

While working Bug 1556068, we introduced some additional code into the upload_cirros.rb script. We should remove the additional items if they are no longer used as they did not address the core issue. It would be beneficial to leverage the upstream glance_image provider instead of the custom ruby script we have today.

https://review.openstack.org/#/c/297679/
https://review.openstack.org/#/c/295828/

[Alex Schultz (alex-schultz)]

Puppet provider work moved to Bug 1566434 as it introduces way more complexity and it's too close to SCF to consider. This bug should be used to track the cleanup of the extra code that was introduced while attempting to address Bug 1556068

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/301896
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=031df97cb9cccb80cda562a2782aaf2c7fe45cba
Submitter: Jenkins
Branch: master

commit 031df97cb9cccb80cda562a2782aaf2c7fe45cba
Author: Alex Schultz <email address hidden>
Date: Tue Apr 5 14:13:52 2016 -0600

    Remove extra loops from upload_cirros script

    This change removes the extra loops from the upload_cirros script that
    were added while attempting to debug Bug 1556068. These extra loops
    could cause the task to exceed the task timeout and ultimately did not
    address the main issue. This change cleans up the extra code that was
    added for debugging purposes now that the previous bug has been closed.

    Change-Id: I26cfe1d0f6f2f6d8fb2e9fbba2cd964574c7bbef
    Closes-Bug: #1563981

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/303477

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/303477
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=cda2e7bbbf07c85e7df4966554aac45acf8ef422
Submitter: Jenkins
Branch: stable/mitaka

commit cda2e7bbbf07c85e7df4966554aac45acf8ef422
Author: Alex Schultz <email address hidden>
Date: Tue Apr 5 14:13:52 2016 -0600

    Remove extra loops from upload_cirros script

    This change removes the extra loops from the upload_cirros script that
    were added while attempting to debug Bug 1556068. These extra loops
    could cause the task to exceed the task timeout and ultimately did not
    address the main issue. This change cleans up the extra code that was
    added for debugging purposes now that the previous bug has been closed.

    Change-Id: I26cfe1d0f6f2f6d8fb2e9fbba2cd964574c7bbef
    Closes-Bug: #1563981
    (cherry picked from commit 031df97cb9cccb80cda562a2782aaf2c7fe45cba)