help text for juju set-constraints needs improving

[Peter Matulis]

e.g.:

Usage: juju set-constraints [options] <service> <constraint>=<value> ...

Summary:
Sets machine constraints for a service.

Options:

-m, --model (= "")
    Model to operate in

Details:
Sets constraints for a service, which are used for all new machines provisioned for that service. They can be viewed with `juju get-constraints`.
By default, the model is the current model.
Service constraints are combined with model constraints, set with `juju set-model-constraints`, for commands (such as 'juju deploy') that provision machines for services. Where model and service constraints overlap, the service constraints take precedence.
Constraints for a specific model can be viewed with `juju get-model-constraints`.
This command requires that the service to have at least one unit. To apply constraints to the first unit set them at the model level or pass them as an argument when deploying.

Examples:

    juju set-constraints mysql mem=8G cpu-cores=4
    juju set-constraints -m mymodel apache2 mem=8G arch=amd64

See also: get-constraints
          get-model-constraints
          set-model-constraints

[Tim Penhey (thumper)]

I'm not sure the second example shown is valid.

It certainly doesn't match the usage. I think it should have the double quotes removed.

[Peter Matulis (petermatulis)]

Corrected and added a few other things.

[Reed O'Brien (reedobrien)]

The details line breaks don't look like paras they look kind of random. Please confirm they are correct.

[Reed O'Brien (reedobrien)]

RB: http://reviews.vapour.ws/r/4556/
PR: https://github.com/juju/juju/pull/5117

[Peter Matulis (petermatulis)]

Re comment #3, right, the RB shows this:

This command requires that the service to have at least one unit. To apply
constraints to
the first unit

That is wrong. Just compare to what is in this bug's description.

[Reed O'Brien (reedobrien)]

That is exactly how it appears in this bug description, which is why I requested confirmation above.
I assume it should not break between "to" and "the", is that correct?

[Matthew Helmke (matthelmke)]

Correct, it should not break between "to" and "the."

[Matthew Helmke (matthelmke)]

I have fixed the description.

[Reed O'Brien (reedobrien)]

Great, thanks!

 I see that the PR didn't merge yesterday evening. So I can easily push this change to that PR. Easy:)