charm tries to restart cinder-backup when it isn't installed

Bug #1563340 reported by Liam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cinder (Juju Charms Collection)
Fix Released
Medium
Liam Young

Bug Description

    The charm has cinder-backup listed as a core service which should always be restarted on changes to config. However, cinder-backup is only present if installed by the cinder-backup subordinate charm. The new pause/resume code will put the charm in a blocked state in this case so it needs fixing.

Liam Young (gnuoy)
Changed in cinder (Juju Charms Collection):
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Liam Young (gnuoy)
milestone: none → 16.04
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/299180

Changed in cinder (Juju Charms Collection):
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-cinder (master)

Reviewed: https://review.openstack.org/299180
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=f434b40b04cada91036842a8d363c6699d7936f8
Submitter: Jenkins
Branch: master

commit f434b40b04cada91036842a8d363c6699d7936f8
Author: Liam Young <email address hidden>
Date: Tue Mar 29 14:01:56 2016 +0000

    cinder-backup service should be optional

    The charm has cinder-backup listed as a core service which should always be
    restarted on changes to config. However, cinder-backup is only present if
    installed by the cinder-backup subordinate charm. The new pause/resume code
    will put the charm in a blocked state in this case so it needs fixing.

    This charm was not using some of the openstack charm conventions such as using
    register_configs with resource_map and using hook_context rather context as
    the key in resource map dict. These have been fixed.

    Closes-Bug: 1563340
    Change-Id: I2fd46e96e60dd60462a4ffa89f7f84e9fd31d234

Changed in cinder (Juju Charms Collection):
status: In Progress → Fix Committed
James Page (james-page)
Changed in cinder (Juju Charms Collection):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.