[2.0a4] Provide DHCP should always allow the user to define a range in case one was already defined
Bug #1563084 reported by
Andres Rodriguez
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Wishlist
|
Steve Rydz |
Bug Description
I had DHCP enabled on a VLAN. I disabled DHCP with the goal of re-enable it with a different dynamic range, however, when I tried to do so I wasn't able to.
1. Disable DHCP
2. Provide DHCP -> it will only allopw you to select rack controller.
However, 2 should have showed me the dynamic range in the subnet I was wanting to use, or was already pre-defined.
Related branches
~steverydz/maas:dhcp-take-two
Merged
into
maas:master
- Anthony Dillon: Approve
- Blake Rouse (community): Approve
- MAAS Lander: Approve
-
Diff: 1889 lines (+1057/-508)9 files modifiedsrc/maasserver/static/js/angular/controllers/dashboard.js (+2/-18)
src/maasserver/static/js/angular/controllers/tests/test_vlan_details.js (+497/-191)
src/maasserver/static/js/angular/controllers/vlan_details.js (+233/-93)
src/maasserver/static/js/angular/directives/ipranges.js (+35/-0)
src/maasserver/static/js/angular/services/manager.js (+17/-0)
src/maasserver/static/partials/ipranges.html (+14/-11)
src/maasserver/static/partials/subnet-details.html (+0/-5)
src/maasserver/static/partials/vlan-details.html (+258/-190)
src/maasserver/static/scss/_utils.scss (+1/-0)
Changed in maas: | |
milestone: | none → 2.0.0 |
importance: | Undecided → Critical |
Changed in maas: | |
status: | New → Triaged |
no longer affects: | maas/2.0 |
Changed in maas: | |
milestone: | 2.1.0 → 2.1.1 |
Changed in maas: | |
milestone: | 2.1.1 → 2.1.2 |
Changed in maas: | |
milestone: | 2.1.2 → 2.1.3 |
Changed in maas: | |
milestone: | 2.2.0 → 2.2.x |
no longer affects: | maas/trunk |
Changed in maas: | |
milestone: | 2.2.x → next |
Changed in maas: | |
assignee: | nobody → Steve Rydz (steverydz) |
Changed in maas: | |
status: | Triaged → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Changed in maas: | |
milestone: | next → none |
To post a comment you must log in.
There are some subtle issues with doing this. When you go to enable DHCP for an interface, you must have at least one dynamic range in one of the subnets associated with the VLAN.
If you have no ranges defined, the decision is easy: show the input fields for start and end IP address in the range, for convenience (so that the user doesn't have to go to the subnet details page to define the range - which by the way, we haven't implemented yet, but that's a separate issue).
If a range is already defined, we could "morph" this convenience feature into a simplistic "edit mode" which allows you to edit the range in case you made a mistake. But there some caveats to doing this:
(1) We must only allow editing if a single range is defined on a single linked subnet.
(2) If the user originally selected an incorrect subnet, there will be no way to select the correct subnet.
(3) We should continue to hide the fields if there is more than one dynamic range defined on the associated subnet(s), possibly with a warning message indicating that ranges already exist.
(4) We should make it clear to the user that they are editing an existing range and not defining a new one.