[2.0] DHCP Snippets are not validated before committed
Bug #1562888 reported by
Andres Rodriguez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
Lee Trager | ||
Bug Description
MAAS is not currently validating the DHCP snippet before it is being committed. This can cause DHCP to be down if a snippet is incorrect.
Related branches
lp:~ltrager/maas/dhcp_snippets_check
- Blake Rouse (community): Approve
-
Diff: 1571 lines (+1067/-51)17 files modifiedsrc/maasserver/api/dhcpsnippets.py (+4/-2)
src/maasserver/api/tests/test_dhcpsnippets.py (+3/-0)
src/maasserver/dhcp.py (+131/-2)
src/maasserver/fields.py (+2/-6)
src/maasserver/forms_dhcpsnippet.py (+34/-22)
src/maasserver/models/signals/__init__.py (+2/-0)
src/maasserver/models/signals/dhcpsnippet.py (+28/-0)
src/maasserver/models/tests/test_dhcpsnippet.py (+28/-0)
src/maasserver/models/tests/test_versionedtextfile.py (+29/-0)
src/maasserver/models/versionedtextfile.py (+9/-2)
src/maasserver/tests/test_dhcp.py (+400/-0)
src/maasserver/tests/test_forms_dhcpsnippet.py (+102/-15)
src/provisioningserver/rpc/cluster.py (+29/-0)
src/provisioningserver/rpc/clusterservice.py (+26/-0)
src/provisioningserver/rpc/dhcp.py (+81/-2)
src/provisioningserver/rpc/tests/test_clusterservice.py (+88/-0)
src/provisioningserver/rpc/tests/test_dhcp.py (+71/-0)
| Changed in maas: | |
| milestone: | none → 2.0.0 |
| importance: | Undecided → Critical |
| assignee: | nobody → Lee Trager (ltrager) |
| status: | New → Confirmed |
| Changed in maas: | |
| status: | Confirmed → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
