Cancel Changes button unexpectedly enabled after loading settings defaults

Bug #1562801 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
In Progress
Low
Pavlo Sumkin
Mitaka
Won't Fix
Low
Pavlo Sumkin
Newton
In Progress
Low
Pavlo Sumkin

Bug Description

Was reproduced on UI with fake nailgun.

STR:
1) create default environment and go to Settings tab
2) change nothing and click Load Defaults button

Expected result: Save Settings and Cancel Changes buttons are locked because no changes were made on the tab
Actual result: these buttons are enabled and can be clicked.

It was figured out that operator_user.password setting gets a new value in each GET /api/clusters/x/attributes/defaults response.

tags: added: area-python
Changed in fuel:
milestone: none → 9.0
assignee: nobody → Fuel Python Team (fuel-python)
Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

I think password shouldn't be regenerated for default settings

Changed in fuel:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
tags: added: ui
removed: need-info
Changed in fuel:
importance: Medium → Undecided
tags: added: need-info
Changed in fuel:
importance: Undecided → Medium
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
importance: Medium → Low
Pavlo Sumkin (ymkins)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Pavlo Sumkin (psumkin)
status: Confirmed → In Progress
Revision history for this message
Pavlo Sumkin (ymkins) wrote :

It's the UX issue: it seems strange that loaded Defaults are differ from Initial.

Another one: we have few sections but can see one at moment and the "Load Defaults" changes all sections.

I propose change the label "Load Defaults" to "Reset All Settings". It's clear that Reset action can change the initial values and affects all sections.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/299897

Revision history for this message
Pavlo Sumkin (ymkins) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-ui (master)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/299897
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.