package xinit 1.3.4-3 failed to install/upgrade: subprocess installed post-installation script returned error exit status 1

[Rachel Greenham]

[Impact]

upgrade fails if /etc/X11/xinit/xinitrc is missing because the postinst script doesn't check for it's existence before running chmod on it.

[Test case]

rm /etc/X11/xinit/xinitrc
/var/lib/dpkg/info/xinit.postinst configure 1

[Regression potential]

nope

------

During remote do-release-upgrade -d from a wily box.

ProblemType: Package
DistroRelease: Ubuntu 16.04
Package: xinit 1.3.4-3
ProcVersionSignature: Ubuntu 4.2.0-34.39-generic 4.2.8-ckt4
Uname: Linux 4.2.0-34-generic x86_64
NonfreeKernelModules: nvidia
.proc.driver.nvidia.registry: Binary: ""
.proc.driver.nvidia.version:
 NVRM version: NVIDIA UNIX x86_64 Kernel Module 340.96 Sun Nov 8 22:33:28 PST 2015
 GCC version: gcc version 5.2.1 20151010 (Ubuntu 5.2.1-22ubuntu2)
ApportVersion: 2.20-0ubuntu3
Architecture: amd64
Date: Fri Mar 25 15:06:11 2016
DistUpgraded: 2016-03-25 15:10:36,689 ERROR failed to import apport python module, can't generate crash: No module named 'xml.dom'
DistroCodename: xenial
DistroVariant: ubuntu
DkmsStatus:
 bbswitch, 0.8, 4.2.0-34-generic, x86_64: installed
 bbswitch, 0.8, 4.4.0-15-generic, x86_64: installed
 nvidia-340, 340.96, 4.2.0-34-generic, x86_64: installed
 nvidia-340, 340.96, 4.4.0-15-generic, x86_64: installed
ErrorMessage: subprocess installed post-installation script returned error exit status 1
GraphicsCard:
 NVIDIA Corporation GT218 [GeForce 210] [10de:0a65] (rev a2) (prog-if 00 [VGA controller])
   Subsystem: ZOTAC International (MCO) Ltd. GT218 [GeForce 210] [19da:1044]
InstallationDate: Installed on 2013-03-11 (1109 days ago)
InstallationMedia: Ubuntu 12.04.2 LTS "Precise Pangolin" - Release amd64 (20130213)
MachineType: System manufacturer System Product Name
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.2.0-34-generic root=UUID=467f6a66-74b5-4070-90db-2150245db2cf ro quiet splash radeon.audio=1 radeon.dpm=1 clocksource=hpet hpet=enable nomdmonddf nomdmonisw nomdmonddf nomdmonisw nomdmonddf nomdmonisw nomdmonddf nomdmonisw nomdmonddf nomdmonisw nomdmonddf nomdmonisw nomdmonddf nomdmonisw
RelatedPackageVersions:
 dpkg 1.18.4ubuntu1
 apt 1.2.7
SourcePackage: xinit
Title: package xinit 1.3.4-3 failed to install/upgrade: subprocess installed post-installation script returned error exit status 1
UpgradeStatus: Upgraded to xenial on 2016-03-25 (0 days ago)
dmi.bios.date: 08/06/2012
dmi.bios.vendor: American Megatrends Inc.
dmi.bios.version: 0803
dmi.board.asset.tag: To Be Filled By O.E.M.
dmi.board.name: P6X58D-E
dmi.board.vendor: ASUSTeK Computer INC.
dmi.board.version: Rev 1.xx
dmi.chassis.asset.tag: Asset-1234567890
dmi.chassis.type: 3
dmi.chassis.vendor: Chassis Manufacture
dmi.chassis.version: Chassis Version
dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvr0803:bd08/06/2012:svnSystemmanufacturer:pnSystemProductName:pvrSystemVersion:rvnASUSTeKComputerINC.:rnP6X58D-E:rvrRev1.xx:cvnChassisManufacture:ct3:cvrChassisVersion:
dmi.product.name: System Product Name
dmi.product.version: System Version
dmi.sys.vendor: System manufacturer
version.compiz: compiz 1:0.9.12.2+16.04.20160318-0ubuntu1
version.ia32-libs: ia32-libs N/A
version.libdrm2: libdrm2 2.4.67-1
version.libgl1-mesa-dri: libgl1-mesa-dri 11.1.2-1ubuntu2
version.libgl1-mesa-dri-experimental: libgl1-mesa-dri-experimental N/A
version.libgl1-mesa-glx: libgl1-mesa-glx 11.1.2-1ubuntu2
version.nvidia-graphics-drivers: nvidia-graphics-drivers-* N/A
version.xserver-xorg-core: xserver-xorg-core 2:1.18.1-1ubuntu4
version.xserver-xorg-input-evdev: xserver-xorg-input-evdev 1:2.10.1-1ubuntu2
version.xserver-xorg-video-ati: xserver-xorg-video-ati 1:7.6.1-1ubuntu2
version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.99.917+git20160218-1ubuntu3
version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:1.0.12-1build2
xserver.bootTime: Thu Mar 17 18:05:50 2016
xserver.configfile: default
xserver.devices:

xserver.logfile: /var/log/Xorg.0.log
xserver.outputs:

xserver.version: 2:1.17.2-1ubuntu9.1

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Timo Aaltonen (tjaalton)]

Setting up xinit (1.3.4-3) ...
chmod: cannot access '/etc/X11/xinit/xinitrc': No such file or directory
dpkg: error processing package xinit (--configure):

did you remove xinitrc at some point?

[Timo Aaltonen (tjaalton)]

nevermind, easy to reproduce

[Martin Pitt (pitti)]

Hello Rachel, or anyone else affected,

Accepted xinit into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xinit/1.3.4-3ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package xinit - 1.3.4-3ubuntu1

---------------
xinit (1.3.4-3ubuntu1) yakkety; urgency=medium

  * postinst: Check that xinitrc exists before trying to chmod it. (LP:
    #1562033)

 -- Timo Aaltonen <email address hidden> Fri, 22 Apr 2016 06:53:18 +0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package xinit - 1.3.4-3ubuntu0.1

---------------
xinit (1.3.4-3ubuntu0.1) xenial; urgency=medium

  * postinst: Check that xinitrc exists before trying to chmod it. (LP:
    #1562033)

 -- Timo Aaltonen <email address hidden> Fri, 22 Apr 2016 06:53:18 +0300

[Chris J Arges (arges)]

The verification of the Stable Release Update for xinit has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.