Upstream Bug #3769: client_netmask not evaluated since Comm redesign
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Squid |
Unknown
|
Unknown
|
|||
squid3 (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
[Impact]
http://
> This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3
releases to have no effect. The designed behaviour of masking client IPs
in logs is now restored.
Upstream issue tracker: http://
In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider.
[Test Case]
1. Install squid3: apt-get install squid3
2. Observe that full client IP is logged to /var/log/
2. Add "client_netmask 255.255.0.0" to config
3. Observe that full client IP is still logged
4. Apply patch
5. Observe that only the first two octets of client IP are logged now.
[Regression Potential]
The fix is minimally invasive and adds only an interaction with the IP::Address class that was not present in the current release. It is also identical to upstream changes except for cosmetic refactoring done between the trusty version of squid3 and when the bug was fixed in upstream.
Regression potential is therefore minimal.
Changed in squid3 (Ubuntu): | |
status: | New → Fix Released |
Second part of patch.