SASS compilation error in cookieconsent 2.0.9

Bug #1560738 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Aaron Wells

Bug Description

If you have the npm package gulp-sass at version 2.2.0 or later, compiling the latest master will cause an error to be displayed:

Building CSS...
[13:05:09] Using gulpfile ~/www/mahara-test/gulpfile.js
[13:05:09] Starting 'css'...
Compiling CSS for htdocs/theme/custom
Compiling CSS for htdocs/theme/default
Compiling CSS for htdocs/theme/modern
Compiling CSS for htdocs/theme/ocean
Compiling CSS for htdocs/theme/primaryschool
Compiling CSS for htdocs/theme/raw
Compiling CSS for htdocs/theme/subthemestarter
Error in plugin 'sass'
Message:
    htdocs/theme/raw/sass/cookieconsent.scss
Error: Invalid CSS after "...n-name:slideUp}": expected ")", was ""
        on line 2 of stdin
>> er;background-image:url(//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/1.0.10
   ------------------------------------------^

[13:05:14] Finished 'css' after 4.72 s

This is due to a change in the cookieconsent SCSS file during the upgrade to CookieConsent 2.0.9 (Bug 1535519)

Revision history for this message
Aaron Wells (u-aaronw) wrote :

High priority, because it completely blocks the compilation of CSS.

Changed in mahara:
importance: Undecided → High
status: New → In Progress
assignee: nobody → Aaron Wells (u-aaronw)
milestone: none → 16.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6236

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6236
Committed: https://git.mahara.org/mahara/mahara/commit/d292c1c324b714713fc46a0ec7782c995a717059
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d292c1c324b714713fc46a0ec7782c995a717059
Author: Aaron Wells <email address hidden>
Date: Wed Mar 23 13:09:14 2016 +1300

Fix SASS compile problem in cookieconsent

Bug 1560738: The problem was a URL starting with "//".
The fix is to surround it with single-quotes.

Change-Id: I8f3f761f99f7d5bb447897240b5c7185720e46b8
behatnotneeded: Covered by existing tests

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.