Stabilize static_route_test

Bug #1560287 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
Medium
Ananth Suryanarayana
Trunk
Fix Committed
Medium
Ananth Suryanarayana

Bug Description

Unit test static_route_test crashes

(gdb) bt
#0 0x00000000015d9ad6 in testing::UnitTest::AddTestPartResult (this=0x1df00e0 <testing::UnitTest::GetInstance()::instance>, result_type=testing::TestPartResult::kNonFatalFailure, file_name=0x1746c10 "controller/src/bgp/test/static_route_test.cc", line_number=2028, message=..., os_stack_trace=...) at /usr/src/gmock/gtest/src/gtest.cc:3796
#1 0x00000000015ce97b in testing::internal::AssertHelper::operator= (this=0x7fffd39baac0, message=...) at /usr/src/gmock/gtest/src/gtest.cc:366
#2 0x0000000000e9fd7b in StaticRouteTest_MultipleVpnRoutes_Test<TypeDefinition<InetTable, Ip4Prefix, InetRoute, InetVpnTable, InetVpnPrefix, InetVpnRoute> >::TestBody (this=0x328cd60) at controller/src/bgp/test/static_route_test.cc:2028
#3 0x00000000015efcd4 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void> (object=0x328cd60, method=&virtual testing::Test::TestBody(), location=0x181cdd3 "the test body") at /usr/src/gmock/gtest/src/gtest.cc:2078
#4 0x00000000015eb556 in testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void> (object=0x328cd60, method=&virtual testing::Test::TestBody(), location=0x181cdd3 "the test body") at /usr/src/gmock/gtest/src/gtest.cc:2114
#5 0x00000000015d3b31 in testing::Test::Run (this=0x328cd60) at /usr/src/gmock/gtest/src/gtest.cc:2151
#6 0x00000000015d430c in testing::TestInfo::Run (this=0x324c930) at /usr/src/gmock/gtest/src/gtest.cc:2326
#7 0x00000000015d499c in testing::TestCase::Run (this=0x32445a0) at /usr/src/gmock/gtest/src/gtest.cc:2444
#8 0x00000000015dafe6 in testing::internal::UnitTestImpl::RunAllTests (this=0x3244270) at /usr/src/gmock/gtest/src/gtest.cc:4261
#9 0x00000000015f0c88 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x3244270, method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x15dad68 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x181d690 "auxiliary test code (environments or event listeners)") at /usr/src/gmock/gtest/src/gtest.cc:2078
#10 0x00000000015ec1cc in testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x3244270, method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x15dad68 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x181d690 "auxiliary test code (environments or event listeners)") at /usr/src/gmock/gtest/src/gtest.cc:2114
#11 0x00000000015d9ca5 in testing::UnitTest::Run (this=0x1df00e0 <testing::UnitTest::GetInstance()::instance>) at /usr/src/gmock/gtest/src/gtest.cc:3875
#12 0x0000000000e4cc28 in RUN_ALL_TESTS () at build/include/gtest/gtest.h:2288
#13 0x0000000000e4bd34 in main (argc=1, argv=0x7fffd39bb278) at controller/src/bgp/test/static_route_test.cc:2209
(gdb) up
#1 0x00000000015ce97b in testing::internal::AssertHelper::operator= (this=0x7fffd39baac0, message=...) at /usr/src/gmock/gtest/src/gtest.cc:366
366 ); // NOLINT
(gdb)
#2 0x0000000000e9fd7b in StaticRouteTest_MultipleVpnRoutes_Test<TypeDefinition<InetTable, Ip4Prefix, InetRoute, InetVpnTable, InetVpnPrefix, InetVpnRoute> >::TestBody (this=0x328cd60) at controller/src/bgp/test/static_route_test.cc:2028
2028 TASK_UTIL_EXPECT_FALSE(partition->IsDBQueueEmpty());
(gdb)
#3 0x00000000015efcd4 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void> (object=0x328cd60, method=&virtual testing::Test::TestBody(), location=0x181cdd3 "the test body") at /usr/src/gmock/gtest/src/gtest.cc:2078
2078 return (object->*method)();
(gdb) down
#2 0x0000000000e9fd7b in StaticRouteTest_MultipleVpnRoutes_Test<TypeDefinition<InetTable, Ip4Prefix, InetRoute, InetVpnTable, InetVpnPrefix, InetVpnRoute> >::TestBody (this=0x328cd60) at controller/src/bgp/test/static_route_test.cc:2028
2028 TASK_UTIL_EXPECT_FALSE(partition->IsDBQueueEmpty());

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/18593
Submitter: Ananth Suryanarayana (<email address hidden>)

Nischal Sheth (nsheth)
tags: added: contrail-control
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/18593
Committed: http://github.org/Juniper/contrail-controller/commit/71d47cf97d10bae27d2adf681bd9117676177879
Submitter: Zuul
Branch: master

commit 71d47cf97d10bae27d2adf681bd9117676177879
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Mar 21 19:06:16 2016 -0700

static_route_test queue empty check not correct

After enabling the processing of queue, check should be for the queue to
become empty, not the otherway around.

Change-Id: I77cdaf5942ae53e5cfb6a6f5e01048091238b62f
Closes-bug:#1560287

Changed in juniperopenstack:
milestone: none → r3.1.0.0-fcs
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/18636
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/18636
Committed: http://github.org/Juniper/contrail-controller/commit/03e480c58eefbeb3e4583432f632dda6eadfe809
Submitter: Zuul
Branch: R3.0

commit 03e480c58eefbeb3e4583432f632dda6eadfe809
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Mar 21 19:06:16 2016 -0700

static_route_test queue empty check not correct

After enabling the processing of queue, check should be for the queue to
become empty, not the otherway around.

Change-Id: I77cdaf5942ae53e5cfb6a6f5e01048091238b62f
Closes-bug:#1560287

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.