The list of enabled Sahara plugins should be configurable

[Luigi Toscano]

The list of Sahara plugins is defined as

  ControllerConfig:
    type: OS::Heat::StructuredConfig
    properties:
      group: os-apply-config
      config:
        hiera:
          [...]
          datafiles:
            [...]
            controller:
              [...]
              mapped_data: # data supplied directly to this deployment configuration, etc
              [...]
                sahara::plugins:
                  - cdh
                  - hdp
                  - mapr
                  - vanilla
                  - spark
                  - storm

Current definition here:
http://git.openstack.org/cgit/openstack/tripleo-heat-templates/tree/puppet/controller.yaml?id=53e2f2dea7d6c7d3e623082141b6fedbc301c276#n1584

The list should be configurable like other parameters. For example the other sahara-related configuration keys allows this:
                sahara::host: {get_input: sahara_api_network}
                [...]
                sahara::admin_password: {get_input: sahara_password}
                sahara::auth_uri: {get_input: keystone_auth_uri}
                sahara::admin_user: sahara
                sahara::identity_uri: {get_input: keystone_identity_uri}
                sahara::use_neutron: true
                sahara::database_connection: {get_input: sahara_dsn}
                [...]

[Carlos Camacho (ccamacho)]

Checking

[Giulio Fidente (gfidente)]

I think a vialble approach here would be to move the list of plugins into the static hieradata file and then parse it as yaml from the client [1]

1. https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L144

[Carlos Camacho (ccamacho)]

I'll try to push the patch today

[Carlos Camacho (ccamacho)]

WIP https://review.openstack.org/#/c/298430/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carlos Camacho (<email address hidden>) on branch: master
Review: https://review.openstack.org/298430
Reason: Abandon if favor of composable roles

[Luigi Toscano (ltoscano)]

Why invalid? The last patch was non relevant anymore due to the split, but the current code still hardcodes the set of enabled plugins. If this was fixed, the bug should be moved to fixed, not invalid.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/392670

[Carlos Camacho (ccamacho)]

Luigi you are right, after the big THT refactor I missed this, I thought it was fixed long time ago.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/392670
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=56c38c1eeac15edc96942bdc2376b5c78e210a3b
Submitter: Jenkins
Branch: master

commit 56c38c1eeac15edc96942bdc2376b5c78e210a3b
Author: Carlos Camacho <email address hidden>
Date: Wed Nov 2 14:45:33 2016 +0100

    Add Sahara plugins list as a configurable parameter

    The hardcoded list should be configurable, and defaulted
    to their current value.

    Change-Id: I517aa61f21c6f4d0975b10a7aa85177c543487e0
    Closes-bug: 1560098

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.