SR-IOV enabled NICs could be added to network bond

[Artem Panchenko]

Fuel version info (9.0 liberty): http://paste.openstack.org/show/490838/

According to the specification [0] SR-IOV enabled NICs can't be included to network bond:

"The following validation should be done in both UI and API:

SR-IOV enabled interface(s) cannot be part of a bond"

But currently I can do that in both GUI and CLI which leads to deployment failure:

2016-03-17 21:59:39 +0000 Scope(Class[main]) (notice): MODULAR: openstack-network/agents/sriov.pp
2016-03-17 21:59:39 +0000 Puppet (err): undefined method `map' for "":String at /etc/puppet/modules/osnailyfacter/modular/openstack-network/agents/sriov.pp:15 on node node-4.test.domain.local

[0] http://specs.openstack.org/openstack/fuel-specs/specs/9.0/support-sriov.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/297116

[Julia Aranovich (jkirnosova)]

Added area-ui tag because Fuel UI changes are needed also.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/297046
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b9cbb70699cb9b6db9ab523edeb02c9229221890
Submitter: Jenkins
Branch: master

commit b9cbb70699cb9b6db9ab523edeb02c9229221890
Author: Georgy Kibardin <email address hidden>
Date: Thu Mar 24 14:42:48 2016 +0300

    Logging nailgun exceptions

    Now there is a special "processor" devoted to this

    Change-Id: I0c4ceb2fe39d7770bf8e19f09e6b1a4cdad7b395
    Related-Bug: #1558996

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/298767

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/298767
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5dd91c9b3ff7712d0c872d92f3dde2267c3a1764
Submitter: Jenkins
Branch: master

commit 5dd91c9b3ff7712d0c872d92f3dde2267c3a1764
Author: Julia Aranovich <email address hidden>
Date: Tue Mar 29 15:22:11 2016 +0300

    Forbid bonding of sr-iov enabled interfaces

    Fuel UI checks bonding type availability conditions
    and forbids bonding of interfaces with no bonding type available

    Partial-Bug: #1558996

    Change-Id: I39a41e87dc7d0441e015f38c28e4547a7010523f

[Julia Aranovich (jkirnosova)]

Fuel UI is fixed for now.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/300454

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/300454
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=719f83c90176608ed5afeec05bf47301f0305c79
Submitter: Jenkins
Branch: master

commit 719f83c90176608ed5afeec05bf47301f0305c79
Author: Julia Aranovich <email address hidden>
Date: Fri Apr 1 15:42:19 2016 +0300

    Layout improvements for interface view

    * fixed margins of title of interface which is unavailable for bonding
    * added default value for bond property translations

    Related-Bug: #1558996

    Change-Id: I04fd610de24c82546ad71ebebe1d7ad988072a94

[Aleksey Kasatkin (alekseyk-ru)]

We need to add validation for case with network template as well.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/297116
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d837ac55853f717679e24f567ca439a89575a31c
Submitter: Jenkins
Branch: master

commit d837ac55853f717679e24f567ca439a89575a31c
Author: Georgy Kibardin <email address hidden>
Date: Thu Mar 24 16:41:37 2016 +0300

    Prohibit SRIOV enabled interfaces in bonds.

    SRIOV enabled interfaces are not allowed in bonds according to
    http://specs.openstack.org/openstack/fuel-specs/specs/9.0/support-sriov.html

    Change-Id: Iadbb090ccfca92339638356bd1358a5213b2ee3b
    Partial-Bug: 1558996

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/306378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306378
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=2f7bd9a7b1dfdbf234d1685ed895233125fc444f
Submitter: Jenkins
Branch: stable/mitaka

commit 2f7bd9a7b1dfdbf234d1685ed895233125fc444f
Author: Georgy Kibardin <email address hidden>
Date: Thu Mar 24 16:41:37 2016 +0300

    Prohibit SRIOV enabled interfaces in bonds.

    SRIOV enabled interfaces are not allowed in bonds according to
    http://specs.openstack.org/openstack/fuel-specs/specs/9.0/support-sriov.html

    Change-Id: Iadbb090ccfca92339638356bd1358a5213b2ee3b
    Partial-Bug: 1558996
    (cherry picked from commit d837ac55853f717679e24f567ca439a89575a31c)

[Artem Panchenko (apanchenko-8)]

verified both GUI and and CLI:

[root@nailgun ~]# fuel node --node-id 22 --network --upload
400 Client Error: Bad Request for url: http://10.109.0.2:8000/api/v1/nodes/22/interfaces/ (Node '22': bond 'bond0' cannot contain SRIOV enabled interface 'ens3f1')

cat /etc/fuel_build_id:
 303
cat /etc/fuel_build_number:
 303
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6344.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8680.noarch
 fuel-mirror-9.0.0-1.mos133.noarch
 shotgun-9.0.0-1.mos88.noarch
 fuel-openstack-metadata-9.0.0-1.mos8680.noarch
 fuel-notify-9.0.0-1.mos8337.noarch
 fuel-ostf-9.0.0-1.mos933.noarch
 python-fuelclient-9.0.0-1.mos313.noarch
 fuel-9.0.0-1.mos6344.noarch
 fuel-utils-9.0.0-1.mos8337.noarch
 fuel-nailgun-9.0.0-1.mos8680.noarch
 rubygem-astute-9.0.0-1.mos742.noarch
 fuel-library9.0-9.0.0-1.mos8337.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-agent-9.0.0-1.mos276.noarch
 fuel-ui-9.0.0-1.mos2676.noarch
 fuel-setup-9.0.0-1.mos6344.noarch
 nailgun-mcagents-9.0.0-1.mos742.noarch
 fuel-misc-9.0.0-1.mos8337.noarch
 python-packetary-9.0.0-1.mos133.noarch
 fuelmenu-9.0.0-1.mos269.noarch
 fuel-bootstrap-cli-9.0.0-1.mos276.noarch
 fuel-migrate-9.0.0-1.mos8337.noarch

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/333975

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/8.0
Review: https://review.openstack.org/333975